Skip to content
This repository has been archived by the owner on Aug 30, 2023. It is now read-only.

exceptions should be sorted oldest to newest #370

Merged
merged 1 commit into from
Apr 20, 2020
Merged

exceptions should be sorted oldest to newest #370

merged 1 commit into from
Apr 20, 2020

Conversation

marandaneto
Copy link
Contributor

@marandaneto marandaneto commented Apr 20, 2020

📢 Type of change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring

📜 Description

exceptions should be sorted oldest to newest
Fix #363

💡 Motivation and Context

Probably related to getsentry/sentry/pull/18227

💚 How did you test it?

running and unit testing

📝 Checklist

  • I reviewed submitted code
  • I added tests to verify changes
  • All tests passing

🔮 Next steps

@codecov-io
Copy link

codecov-io commented Apr 20, 2020

Codecov Report

❗ No coverage uploaded for pull request base (master@5d5aeba). Click here to learn what that means.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #370   +/-   ##
=========================================
  Coverage          ?   58.92%           
  Complexity        ?      759           
=========================================
  Files             ?       87           
  Lines             ?     3540           
  Branches          ?      341           
=========================================
  Hits              ?     2086           
  Misses            ?     1302           
  Partials          ?      152           
Impacted Files Coverage Δ Complexity Δ
...in/java/io/sentry/core/SentryExceptionFactory.java 92.68% <100.00%> (ø) 8.00 <0.00> (?)
.../java/io/sentry/core/SentryEnvelopeItemHeader.java 81.81% <0.00%> (ø) 6.00% <0.00%> (?%)
...c/main/java/io/sentry/core/protocol/Mechanism.java 37.93% <0.00%> (ø) 6.00% <0.00%> (?%)
...rc/main/java/io/sentry/core/CircularFifoQueue.java 34.95% <0.00%> (ø) 17.00% <0.00%> (?%)
...java/io/sentry/core/protocol/SentryStackFrame.java 31.66% <0.00%> (ø) 13.00% <0.00%> (?%)
...rc/main/java/io/sentry/core/protocol/SentryId.java 75.86% <0.00%> (ø) 10.00% <0.00%> (?%)
...try/core/transport/RetryingThreadPoolExecutor.java 78.94% <0.00%> (ø) 7.00% <0.00%> (?%)
...re/src/main/java/io/sentry/core/protocol/User.java 95.12% <0.00%> (ø) 18.00% <0.00%> (?%)
.../src/main/java/io/sentry/core/protocol/Device.java 0.00% <0.00%> (ø) 0.00% <0.00%> (?%)
...main/java/io/sentry/core/util/ApplyScopeUtils.java 50.00% <0.00%> (ø) 3.00% <0.00%> (?%)
... and 78 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5d5aeba...7a30064. Read the comment docs.

Copy link
Member

@bruno-garcia bruno-garcia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I saw it was changed in the UI, might need to change in other SDKs too now

@marandaneto marandaneto merged commit 793c9ce into getsentry:master Apr 20, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Exception cause is reported instead of actual exception since SDK 2.0.0
3 participants