Skip to content
This repository has been archived by the owner on Aug 30, 2023. It is now read-only.

if retry after header has empty categories, apply retry after to all of them #377

Merged
merged 5 commits into from
Apr 27, 2020
Merged

if retry after header has empty categories, apply retry after to all of them #377

merged 5 commits into from
Apr 27, 2020

Conversation

marandaneto
Copy link
Contributor

@marandaneto marandaneto commented Apr 24, 2020

📢 Type of change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring

📜 Description

if retry after header has empty categories, apply retry after to all of them.

💡 Motivation and Context

the current implementation was not handling empty categories.

💚 How did you test it?

📝 Checklist

  • I reviewed submitted code
  • I added tests to verify changes
  • All tests passing

🔮 Next steps

@codecov-io
Copy link

codecov-io commented Apr 27, 2020

Codecov Report

Merging #377 into master will decrease coverage by 0.04%.
The diff coverage is 50.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #377      +/-   ##
============================================
- Coverage     59.24%   59.20%   -0.05%     
- Complexity      767      768       +1     
============================================
  Files            87       87              
  Lines          3548     3554       +6     
  Branches        343      345       +2     
============================================
+ Hits           2102     2104       +2     
- Misses         1295     1297       +2     
- Partials        151      153       +2     
Impacted Files Coverage Δ Complexity Δ
...n/java/io/sentry/core/transport/HttpTransport.java 66.45% <50.00%> (-1.29%) 20.00 <0.00> (+1.00) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 403e196...f528106. Read the comment docs.

@marandaneto marandaneto merged commit 2e84810 into getsentry:master Apr 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants