Skip to content
This repository has been archived by the owner on Aug 30, 2023. It is now read-only.

enhancement: Bump NDK version #466

Merged
merged 3 commits into from
Sep 9, 2020
Merged

enhancement: Bump NDK version #466

merged 3 commits into from
Sep 9, 2020

Conversation

marandaneto
Copy link
Contributor

@marandaneto marandaneto commented Jun 20, 2020

📢 Type of change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring

📜 Description

enhancement: Bump NDK version

💡 Motivation and Context

enhancement: Bump NDK version
remove ndk install from GH actions, now mac and ubuntu have it by default.

💚 How did you test it?

📝 Checklist

  • I reviewed submitted code
  • I added tests to verify changes
  • All tests passing

🔮 Next steps

waiting for this https://discuss.lgtm.com/t/android-project-build-is-not-working/2587/5
otherwise, LGTM will fail

https://github.community/t/lgtm-missing-latest-stable-android-ndk-version/122667

@marandaneto marandaneto marked this pull request as draft June 20, 2020 12:58
Copy link
Member

@bruno-garcia bruno-garcia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good it’s there by default

@marandaneto marandaneto marked this pull request as ready for review September 9, 2020 07:46
@marandaneto marandaneto merged commit 6bb62d5 into getsentry:master Sep 9, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants