This repository has been archived by the owner on Aug 30, 2023. It is now read-only.
Attach breadcrumbs to events triggered in Logback integration. #532
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maciejwalkowiak
requested review from
bruno-garcia and
marandaneto
as code owners
| @@ -213,4 +225,29 @@ class SentryAppenderTest { | |||
| }) | |||
| } | |||
| } | |||
|
|
|||
| @Test | |||
| fun `attaches breadcrumbs`() { | |||
There was a problem hiding this comment.
Suggested change
| fun `attaches breadcrumbs`() { | |
| fun `attaches breadcrumbs with level higher than minimumBreadcrumbLevel`() { |
Can we have some more use cases here? Like level higher than breadcrumb is captured as event but not added as breadcrumbs.
Set only level for breadcrumb, only for event, etc?
| fixture = Fixture(minimumBreadcrumbLevel = Level.DEBUG, minimumEventLevel = WARN) | ||
| val utcTime = LocalDateTime.now(ZoneId.of("UTC")) | ||
|
|
||
| fixture.logger.debug("this should be a breadcrumb #1") |
There was a problem hiding this comment.
One test case could make sure this doesn't end up in a crumb because min level is Info.
Actually a test case for default would be nice, and default would be Info or higher for Breadcrumb and Error or higher for event.
sentry-samples/sentry-samples-logback/src/main/resources/logback.xml
Outdated
Show resolved
Hide resolved
sentry-samples/sentry-samples-logback/src/main/resources/logback.xml
Outdated
Show resolved
Hide resolved
bruno-garcia
approved these changes
Aug 31, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📢 Type of change
📜 Description
Logback integration gets now an option to set
minimumEventLevelandminimumBreadcrumbLevel. Breadcrumbs are attached to current scope and sent along with followingSentryEvent.💡 Motivation and Context
Requested by @bruno-garcia.
📝 Checklist