Fix iOS dropping envelopes with UTF16 characters #150
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It may be time consuming but ideally we should have an integration tests testing the integration of the Capacitor + Native SDKs. |
| @@ -89,6 +89,16 @@ public class SentryCapacitor: CAPPlugin { | |||
| call.resolve() | |||
| } | |||
|
|
|||
| @objc func getStringBytesLength(_ call: CAPPluginCall) { | |||
There was a problem hiding this comment.
Is this called from JS for both iOS and Android?
There was a problem hiding this comment.
Yes, but only Android implemented it
in this case on iOS it was falling back to the value set in JS, which worked for most cases but not all of them.
No because the same was only using UTF8 characters. |
bruno-garcia
approved these changes
Mar 14, 2022
bruno-garcia
changed the title
Instructions and example for changelogPlease add an entry to ## Unreleased
### Fixes/Features
- Fix iOS dropping envelopes with UTF16 characters ([#150](https://github.com/getsentry/sentry-capacitor/pull/150))If none of the above apply, you can opt out of this check by adding |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not sure how but, getStringBytesLength was missing from iOS so I just implemented it
Fixes #124 and #100
Tested event: https://sentry.io/organizations/sentry-sdks/discover/sentry-capacitor:b7e9eb1c22f34d1b84f0b085db3a733a/?field=title&field=event.type&field=project&field=user.display&field=timestamp&name=All+Events&project=5522756&query=&sort=-timestamp&statsPeriod=1h&yAxis=count%28%29