Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump Sentry JavaScript 7.73.0 #479

Merged
merged 3 commits into from
Oct 16, 2023
Merged

Bump Sentry JavaScript 7.73.0 #479

merged 3 commits into from
Oct 16, 2023

Conversation

lucas-zimerman
Copy link
Collaborator

Additionally, the replay package was removed from the samples since it is already bundled with the main SDK.

Copy link
Member

@krystofwoldrich krystofwoldrich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

"@sentry/angular": "7.70.0-beta.1",
"@sentry/angular": "7.73.0",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not related to this PR, but should we use @sentry/angular-ivy since the @angular packages in the examples are ~13?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Despite working you're correct, if we recommend using the angular ivy package we also should be using it, I'll open a do to PR to fix it.

@lucas-zimerman lucas-zimerman merged commit 60250d1 into main Oct 16, 2023
6 checks passed
@lucas-zimerman lucas-zimerman deleted the bump/sentry-js-7-73-0 branch October 16, 2023 14:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants