-
-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump: JavaScript 7.93.0 #573
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Feb 16, 2024
Merged
* Add tests, fix errors and enhance sample * fix working path * test * remove working directory * add sample * add test * test * fix sample path * ignore cli errors * fix hybridsdk * update lock * wrong slash * update samples * small fixes * test * test * missing esm * test * oops * removed unused Native Linked Errors integration, also fixed missing vue build script, removed tests for the removed code * Update test/integrations/rewriteframes.test.ts Co-authored-by: Kryštof Woldřich <31292499+krystofwoldrich@users.noreply.github.com> * Update test/integrations/rewriteframes.test.ts Co-authored-by: Kryštof Woldřich <31292499+krystofwoldrich@users.noreply.github.com> * remove client * Add capacitor production tests * removed unrelated tests * add development test * Update src/integrations/rewriteframes.ts --------- Co-authored-by: Kryštof Woldřich <31292499+krystofwoldrich@users.noreply.github.com>
Co-authored-by: Kryštof Woldřich <31292499+krystofwoldrich@users.noreply.github.com>
lucas-zimerman
commented
Feb 23, 2024
krystofwoldrich
approved these changes
Mar 1, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀
I have only one nit about the eventorigin
integration callback name, I'll leave that up to you.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR Bumps Sentry JavaScript to version 7.93
There are internal break changes that required some code change but it shouldn't have any impact on the user side.
Before approval, this PR depends on #572 to fix the rewriteframes tests.