Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump: Sentry JavaScript 7.114.0 #645

Merged
merged 5 commits into from
May 21, 2024
Merged

Bump: Sentry JavaScript 7.114.0 #645

merged 5 commits into from
May 21, 2024

Conversation

lucas-zimerman
Copy link
Collaborator

@lucas-zimerman lucas-zimerman commented May 11, 2024

This PR bumps Sentry from version 93 up to 114.0.
No break changes were seen on both Windows and MacOS

@lucas-zimerman lucas-zimerman marked this pull request as ready for review May 11, 2024 02:44
@@ -48,5 +48,6 @@ module.exports = {
'@sentry-internal/sdk/no-optional-chaining': 'off',
'@sentry-internal/sdk/no-nullish-coalescing': 'off',
'@sentry-internal/sdk/no-class-field-initializers': 'off',
'deprecation/deprecation': 'off',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are there many deprecation warnings? (More than ~20?)

If so this fine, but if it's not too many I would prefer disabling it locally to make it obvious which APIs will need to be updated in sentry-capacitor and the examples.

But let's keep it for next PR.

Copy link
Member

@krystofwoldrich krystofwoldrich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

* v5 to v6

* remove capacitor 2 sample, update capacitor 5 to capacitor 6 as a sample, add script to skip pod install on windows

* changelog

* fix sample

* V3 sample and requested changes from PR

* fix windows pod path
@lucas-zimerman lucas-zimerman merged commit 577aad8 into main May 21, 2024
7 checks passed
@lucas-zimerman lucas-zimerman deleted the bump/7.114.0 branch May 21, 2024 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants