sample rate as string

getsentry · Jul 7, 2022 · 1e20433 · 1e20433
1 parent ebd353c
commit 1e20433
Show file tree

Hide file tree

Showing 7 changed files with 13 additions and 13 deletions.
diff --git a/Sources/Sentry/SentryBaggage.m b/Sources/Sentry/SentryBaggage.m
@@ -15,7 +15,7 @@ - (instancetype)initWithTraceId:(SentryId *)traceId
                     releaseName:(nullable NSString *)releaseName
                     environment:(nullable NSString *)environment
                     userSegment:(nullable NSString *)userSegment
-                     sampleRate:(nullable NSNumber *)sampleRate
+                     sampleRate:(nullable NSString *)sampleRate
 {
 
     if (self = [super init]) {

diff --git a/Sources/Sentry/SentryTraceContext.m b/Sources/Sentry/SentryTraceContext.m
@@ -18,7 +18,7 @@ - (instancetype)initWithTraceId:(SentryId *)traceId
                     releaseName:(nullable NSString *)releaseName
                     environment:(nullable NSString *)environment
                     userSegment:(nullable NSString *)userSegment
-                     sampleRate:(nullable NSNumber *)sampleRate
+                     sampleRate:(nullable NSString *)sampleRate
 {
     if (self = [super init]) {
         _traceId = traceId;
@@ -53,9 +53,9 @@ - (nullable instancetype)initWithTracer:(SentryTracer *)tracer
         [scope.userObject.data[@"segment"] isKindOfClass:[NSString class]])
         userSegment = scope.userObject.data[@"segment"];
 
-    NSNumber *sampleRate = nil;
+    NSString *sampleRate = nil;
     if ([tracer.context isKindOfClass:[SentryTransactionContext class]]) {
-        sampleRate = [(SentryTransactionContext *)tracer.context sampleRate];
+        sampleRate = [NSString stringWithFormat:@"%@", [(SentryTransactionContext *)tracer.context sampleRate]];
     }
 
     return [self initWithTraceId:tracer.context.traceId
@@ -81,7 +81,7 @@ - (nullable instancetype)initWithDict:(NSDictionary<NSString *, id> *)dictionary
     } else {
         userSegment = dictionary[@"user_segment"];
     }
-
+            
     return [self initWithTraceId:traceId
                        publicKey:publicKey
                      releaseName:dictionary[@"release"]
@@ -116,7 +116,7 @@ - (SentryBaggage *)toBaggage
         [result setValue:_userSegment forKey:@"user_segment"];
 
     if (_sampleRate != nil)
-        [result setValue:[NSString stringWithFormat:@"%@", _sampleRate] forKey:@"sample_rate"];
+        [result setValue:_sampleRate forKey:@"sample_rate"];
 
     return result;
 }

diff --git a/Sources/Sentry/include/SentryBaggage.h b/Sources/Sentry/include/SentryBaggage.h
@@ -47,14 +47,14 @@ static NSString *const SENTRY_BAGGAGE_HEADER = @"baggage";
 /**
  * The sample rate.
  */
-@property (nullable, nonatomic, readonly) NSNumber *sampleRate;
+@property (nullable, nonatomic, readonly) NSString *sampleRate;
 
 - (instancetype)initWithTraceId:(SentryId *)traceId
                       publicKey:(NSString *)publicKey
                     releaseName:(nullable NSString *)releaseName
                     environment:(nullable NSString *)environment
                     userSegment:(nullable NSString *)userSegment
-                     sampleRate:(nullable NSNumber *)sampleRate;
+                     sampleRate:(nullable NSString *)sampleRate;
 
 - (NSString *)toHTTPHeader;
 

diff --git a/Sources/Sentry/include/SentryTraceContext.h b/Sources/Sentry/include/SentryTraceContext.h
@@ -37,7 +37,7 @@ NS_ASSUME_NONNULL_BEGIN
 /**
  * Sample rate used for this trace.
  */
-@property (nullable, nonatomic) NSNumber *sampleRate;
+@property (nullable, nonatomic) NSString *sampleRate;
 
 /**
  * Initializes a SentryTraceContext with given properties.
@@ -47,7 +47,7 @@ NS_ASSUME_NONNULL_BEGIN
                     releaseName:(nullable NSString *)releaseName
                     environment:(nullable NSString *)environment
                     userSegment:(nullable NSString *)userSegment
-                     sampleRate:(nullable NSNumber *)sampleRate;
+                     sampleRate:(nullable NSString *)sampleRate;
 
 /**
  * Initializes a SentryTraceContext with data from scope and options.

diff --git a/Tests/SentryTests/Helper/SentrySerializationTests.swift b/Tests/SentryTests/Helper/SentrySerializationTests.swift
@@ -4,7 +4,7 @@ class SentrySerializationTests: XCTestCase {
 
     private class Fixture {
         static var invalidData = "hi".data(using: .utf8)!
-        static var traceContext = SentryTraceContext(trace: SentryId(), publicKey: "PUBLIC_KEY", releaseName: "RELEASE_NAME", environment: "TEST", userSegment: "some segment", sampleRate: NSNumber(value: 0.25))
+        static var traceContext = SentryTraceContext(trace: SentryId(), publicKey: "PUBLIC_KEY", releaseName: "RELEASE_NAME", environment: "TEST", userSegment: "some segment", sampleRate: "0.25")
     }
 
     func testSentryEnvelopeSerializer_WithSingleEvent() {

diff --git a/Tests/SentryTests/Transaction/SentryBaggageTests.swift b/Tests/SentryTests/Transaction/SentryBaggageTests.swift
@@ -5,7 +5,7 @@ import XCTest
 class SentryBaggageTests: XCTestCase {
 
     func test_baggageToHeader() {
-        let header = SentryBaggage(trace: SentryId.empty, publicKey: "publicKey", releaseName: "release name", environment: "teste", userSegment: "test user", sampleRate: 0.49).toHTTPHeader()
+        let header = SentryBaggage(trace: SentryId.empty, publicKey: "publicKey", releaseName: "release name", environment: "teste", userSegment: "test user", sampleRate: "0.49").toHTTPHeader()
 
         XCTAssertEqual(header, "sentry-environment=teste,sentry-public_key=publicKey,sentry-release=release%20name,sentry-sample_rate=0.49,sentry-trace_id=00000000000000000000000000000000,sentry-user_segment=test%20user")
     }

diff --git a/Tests/SentryTests/Transaction/SentryTraceStateTests.swift b/Tests/SentryTests/Transaction/SentryTraceStateTests.swift
@@ -12,7 +12,7 @@ class SentryTraceContextTests: XCTestCase {
         let tracer: SentryTracer
         let userId = "SomeUserID"
         let userSegment = "Test Segment"
-        let sampleRate = NSNumber(value: 0.45)
+        let sampleRate = "0.45"
         let traceId: SentryId
         let publicKey = "SentrySessionTrackerTests"
         let releaseName = "SentrySessionTrackerIntegrationTests"