Skip to content

Commit

Permalink
ci: Remove schedule of unit tests (#3030)
Browse files Browse the repository at this point in the history
We hypothesized that tests take longer and fail more often when the US is
online. We didn't find strong evidence for this claim. There could be a slight
correlation between the US being online and the tests failing more often.
Even with a weak correlation, there isn't much we can do except improve the
test suite. Therefore, keeping the tests running on a schedule doesn't make
sense.
  • Loading branch information
philipphofmann committed May 15, 2023
1 parent f938d24 commit aeec206
Showing 1 changed file with 0 additions and 8 deletions.
8 changes: 0 additions & 8 deletions .github/workflows/test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -26,14 +26,6 @@ on:
- 'Samples/iOS-Swift/iOS-Swift.xcodeproj/xcshareddata/xcschemes/iOS-Swift.xcscheme'
- 'Samples/macOS-Swift/macOS-Swift.xcodeproj/xcshareddata/xcschemes/macOS-Swift.xcscheme'
- 'Samples/iOS-ObjectiveC/iOS-ObjectiveC.xcodeproj/xcshareddata/xcschemes/iOS-ObjectiveC.xcscheme'

schedule:
# Run tests every hour to get some data on how long they take and how often they fail.
# We hypothesize that tests take longer and fail more often when the US is online.
# The plan is to remove this after a week or so, once we have enough data.
# We didn't choose 0 to minimize collisions with other workflows.
# Run every hour at 17 minutes past the hour.
- cron: '47 * * * *'

jobs:
build-test-server:
Expand Down

0 comments on commit aeec206

Please sign in to comment.