Skip to content

Commit

Permalink
test: Replace fatalError with XCTUnwrap (#2870)
Browse files Browse the repository at this point in the history
Replace fatalError with XCTUnwrap in SentryTracerTests.
  • Loading branch information
philipphofmann committed Apr 6, 2023
1 parent 90d17d3 commit e1eed6b
Showing 1 changed file with 9 additions and 10 deletions.
19 changes: 9 additions & 10 deletions Tests/SentryTests/Transaction/SentryTracerTests.swift
Original file line number Diff line number Diff line change
Expand Up @@ -123,7 +123,7 @@ class SentryTracerTests: XCTestCase {
clearTestState()
}

func testFinish_WithChildren_WaitsForAllChildren() {
func testFinish_WithChildren_WaitsForAllChildren() throws {
let sut = fixture.getSut()
let child = sut.startChild(operation: fixture.transactionOperation)
sut.finish()
Expand All @@ -144,7 +144,7 @@ class SentryTracerTests: XCTestCase {

assertOneTransactionCaptured(sut)

let serialization = getSerializedTransaction()
let serialization = try getSerializedTransaction()
let spans = serialization["spans"]! as! [[String: Any]]

let tracerTimestamp: NSDate = sut.timestamp! as NSDate
Expand Down Expand Up @@ -839,7 +839,7 @@ class SentryTracerTests: XCTestCase {
XCTAssertTrue(sutOnScope === fixture.hub.scope.span)
}

func testFinishAsync() {
func testFinishAsync() throws {
let sut = fixture.getSut()
let child = sut.startChild(operation: fixture.transactionOperation)
sut.finish()
Expand Down Expand Up @@ -871,7 +871,7 @@ class SentryTracerTests: XCTestCase {

assertOneTransactionCaptured(sut)

let spans = getSerializedTransaction()["spans"]! as! [[String: Any]]
let spans = try getSerializedTransaction()["spans"]! as! [[String: Any]]
XCTAssertEqual(spans.count, children * (grandchildren + 1) + 1)
}

Expand Down Expand Up @@ -906,7 +906,7 @@ class SentryTracerTests: XCTestCase {
XCTAssertEqual(1, transactionsWithAppStartMeasurement.count)
}

func testAddingSpansOnDifferentThread_WhileFinishing_DoesNotCrash() {
func testAddingSpansOnDifferentThread_WhileFinishing_DoesNotCrash() throws {
let sut = fixture.getSut(waitForChildren: false)

let children = 1_000
Expand Down Expand Up @@ -943,7 +943,7 @@ class SentryTracerTests: XCTestCase {
queue.activate()
group.wait()

let spans = getSerializedTransaction()["spans"]! as! [[String: Any]]
let spans = try getSerializedTransaction()["spans"]! as! [[String: Any]]
XCTAssertGreaterThanOrEqual(spans.count, children)
}

Expand Down Expand Up @@ -1013,10 +1013,9 @@ class SentryTracerTests: XCTestCase {
fixture.currentDateProvider.internalDispatchNow = newNow
}

private func getSerializedTransaction() -> [String: Any] {
guard let transaction = fixture.hub.capturedEventsWithScopes.first?.event else {
fatalError("Event must not be nil.")
}
private func getSerializedTransaction() throws -> [String: Any] {
let transaction = try XCTUnwrap( fixture.hub.capturedEventsWithScopes.first?.event)

return transaction.serialize()
}

Expand Down

0 comments on commit e1eed6b

Please sign in to comment.