Merge 7e1de03 into 9fa25c2

getsentry · Sep 5, 2023 · f49a024 · f49a024
2 parents 9fa25c2 + 7e1de03
commit f49a024
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 2 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,5 +1,11 @@
 # Changelog
 
+## Unreleased
+
+### Features
+
+- Rename "http.method" to "http.request.method" for network Spans #3268
+
 ## 8.11.0
 
 ### Features

diff --git a/Sources/Sentry/SentryNetworkTracker.m b/Sources/Sentry/SentryNetworkTracker.m
@@ -179,7 +179,8 @@ - (void)urlSessionTaskResume:(NSURLSessionTask *)sessionTask
                                                             safeUrl.sanitizedUrl]];
                 netSpan.origin = SentryTraceOriginAutoHttpNSURLSession;
 
-                [netSpan setDataValue:sessionTask.currentRequest.HTTPMethod forKey:@"http.method"];
+                [netSpan setDataValue:sessionTask.currentRequest.HTTPMethod
+                               forKey:@"http.request.method"];
                 [netSpan setDataValue:safeUrl.sanitizedUrl forKey:@"url"];
                 [netSpan setDataValue:@"fetch" forKey:@"type"];
 

diff --git a/Tests/SentryTests/Integrations/Performance/Network/SentryNetworkTrackerTests.swift b/Tests/SentryTests/Integrations/Performance/Network/SentryNetworkTrackerTests.swift
@@ -837,7 +837,7 @@ class SentryNetworkTrackerTests: XCTestCase {
         }
 
         let path = span.data["url"] as? String
-        let method = span.data["http.method"] as? String
+        let method = span.data["http.request.method"] as? String
         let requestType = span.data["type"] as? String
         let query = span.data["http.query"] as? String
         let fragment = span.data["http.fragment"] as? String