Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Respect already existing baggage header on outgoing http requests #1911

Closed
brustolin opened this issue Jun 22, 2022 · 0 comments · Fixed by #1995
Closed

Respect already existing baggage header on outgoing http requests #1911

brustolin opened this issue Jun 22, 2022 · 0 comments · Fixed by #1995
Assignees
@kevinrenskers
Labels
Platform: Cocoa

Comments

@brustolin
Copy link
Contributor

Description

Preparing for Dynamic Sampling we added the baggage header to outgoing http requests.
Since this is an open protocol, other products may also use this header and we should not replace it.

If the header already exists we should just append sentry specific items.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kevinrenskers kevinrenskers

Labels
Platform: Cocoa
Projects
Mobile & Cross Platform SDK
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: Respect existing baggage header instead of overwriting it getsentry/sentry-cocoa
3 participants
@kevinrenskers @philipphofmann @brustolin