Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set sample rate to 0 if out of range #986

Closed
philipphofmann opened this issue Mar 10, 2021 · 0 comments · Fixed by #1074
Closed

Set sample rate to 0 if out of range #986

philipphofmann opened this issue Mar 10, 2021 · 0 comments · Fixed by #1074
Assignees
@philipphofmann
Projects
Mobile Platform Team Archived
Milestone
7.0.0

Comments

@philipphofmann
Copy link
Member

philipphofmann commented Mar 10, 2021 •
edited

Set the sample rate to 0 if it is smaller than 0 or greater than 1 for tracesSampleRate, tracesSampler, and to 1 for sampleRate in SentryOptions.
@philipphofmann philipphofmann added this to the 7.0.0 milestone Mar 10, 2021
@philipphofmann philipphofmann added this to Backlog in Mobile Platform Team Archived via automation Mar 10, 2021
@philipphofmann philipphofmann moved this from Backlog to Next in Mobile Platform Team Archived Mar 10, 2021
@philipphofmann philipphofmann mentioned this issue Mar 10, 2021
Merged
6 tasks
@philipphofmann philipphofmann added this to Todo in kanban Mar 10, 2021
@brustolin brustolin moved this from Todo to InProgress in kanban Mar 10, 2021
@brustolin brustolin moved this from InProgress to Done in kanban Mar 11, 2021
@philipphofmann philipphofmann mentioned this issue Mar 11, 2021
Merged
philipphofmann added a commit that referenced this issue Apr 22, 2021
@philipphofmann
ref: Set sample rate to default if out of range
79d9b45 
Set sampleRate, tracesSampleRate and tracesSampler to default value when
a provided value is out of range.

Fixes GH-986
philipphofmann added a commit that referenced this issue Apr 22, 2021
@philipphofmann
ref: Set sample rates to default if out of range
b6aee1d 
Set sampleRate, tracesSampleRate, and tracesSampler to default value when
a provided value is out of range.

Fixes GH-986
@philipphofmann philipphofmann mentioned this issue Apr 22, 2021
Merged
6 tasks
@philipphofmann philipphofmann self-assigned this Apr 23, 2021
@philipphofmann philipphofmann moved this from Done to InProgress in kanban Apr 23, 2021
@philipphofmann philipphofmann moved this from Next to In Progress in Mobile Platform Team Archived Apr 23, 2021
@philipphofmann philipphofmann removed this from InProgress in kanban Apr 23, 2021
Mobile Platform Team Archived automation moved this from In Progress to Done Apr 23, 2021
philipphofmann added a commit that referenced this issue Apr 23, 2021
@philipphofmann @bruno-garcia
ref: Set sample rates to default if out of range (#1074)
f893682 
Set sampleRate, tracesSampleRate, and tracesSampler to default value when
a provided value is out of range.

Fixes GH-986

Co-authored-by: Bruno Garcia <bruno@brunogarcia.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@philipphofmann philipphofmann

Labels
None yet
Projects
No open projects
Mobile Platform Team Archived
Done
Milestone
7.0.0
Development

Successfully merging a pull request may close this issue.

ref: Set sample rates to default if out of range getsentry/sentry-cocoa
2 participants
@philipphofmann @brustolin