-
-
Notifications
You must be signed in to change notification settings - Fork 308
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Allow setting SDK info with Options initWithDict #1793
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One issue to address. Thanks for doing this 🚀
0037faf
to
3568372
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @vaind 💯
Codecov Report
@@ Coverage Diff @@
## master #1793 +/- ##
==========================================
- Coverage 92.73% 91.68% -1.05%
==========================================
Files 198 198
Lines 9047 9049 +2
==========================================
- Hits 8390 8297 -93
- Misses 657 752 +95
Continue to review full report at Codecov.
|
📜 Description
Enables users to override the SDK info
💡 Motivation and Context
This allows other SDKs that use sentry-cocoa internally to identify the events. Enables getsentry/sentry-unity#616
💚 How did you test it?
Added a test case
📝 Checklist