Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Allow setting SDK info with Options initWithDict #1793

Merged
merged 2 commits into from
May 4, 2022

Conversation

vaind
Copy link
Collaborator

@vaind vaind commented May 3, 2022

📜 Description

Enables users to override the SDK info

💡 Motivation and Context

This allows other SDKs that use sentry-cocoa internally to identify the events. Enables getsentry/sentry-unity#616

💚 How did you test it?

Added a test case

📝 Checklist

  • I reviewed the submitted code
  • I added tests to verify the changes
  • I updated the docs if needed
  • Review from the native team if needed
  • No breaking changes

Copy link
Member

@philipphofmann philipphofmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One issue to address. Thanks for doing this 🚀

Sources/Sentry/SentryOptions.m Show resolved Hide resolved
Copy link
Contributor

@brustolin brustolin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@philipphofmann philipphofmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @vaind 💯

@philipphofmann philipphofmann changed the title feat: Allow setting SDK info (name & version) with Options initWithDict feat: Allow setting SDK info with Options initWithDict May 4, 2022
@codecov-commenter
Copy link

Codecov Report

Merging #1793 (0037faf) into master (83376a2) will decrease coverage by 1.04%.
The diff coverage is 100.00%.

❗ Current head 0037faf differs from pull request most recent head 8f3e2ad. Consider uploading reports for the commit 8f3e2ad to get more accurate results

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1793      +/-   ##
==========================================
- Coverage   92.73%   91.68%   -1.05%     
==========================================
  Files         198      198              
  Lines        9047     9049       +2     
==========================================
- Hits         8390     8297      -93     
- Misses        657      752      +95     
Impacted Files Coverage Δ
Sources/Sentry/SentryOptions.m 99.57% <100.00%> (+<0.01%) ⬆️
Sources/Sentry/SentryProfilingLogging.mm 0.00% <0.00%> (-85.72%) ⬇️
Sources/Sentry/SentryMachLogging.cpp 0.00% <0.00%> (-31.29%) ⬇️
Sources/Sentry/include/SentryMachLogging.hpp 55.55% <0.00%> (-22.23%) ⬇️
Sources/Sentry/include/SentryProfilingLogging.hpp 57.14% <0.00%> (-9.53%) ⬇️
Sources/Sentry/SentryThreadHandle.cpp 69.06% <0.00%> (-3.60%) ⬇️
Sources/Sentry/SentryBacktrace.cpp 91.57% <0.00%> (-1.06%) ⬇️
Sources/Sentry/SentryTracer.m 98.31% <0.00%> (-0.34%) ⬇️
Sources/Sentry/SentryProfiler.mm 93.41% <0.00%> (+1.79%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4b3c9f1...8f3e2ad. Read the comment docs.

@philipphofmann philipphofmann merged commit 7761aff into getsentry:master May 4, 2022
@vaind vaind deleted the feat/sdk-info-setting branch May 11, 2022 10:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants