fix: iOS13 Swift Sample is not compiling #1935
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
@brustolin, can we compile this in CI to avoid the same problem in the future, please? I think the build workflow would be the correct place.
Agreed. This is probably a good task for me to learn how to create tasks for CI to run. |
kevinrenskers
added a commit
that referenced
this pull request
Jul 5, 2022
* master: build(deps): bump fastlane from 2.206.2 to 2.207.0 (#1937) fixing sample not compiling (#1935) style: Configure the root of the project to use four spaces for indentation (#1934) meta: Add LOGAF scale to Contributing (#1933) meta: Mention draft PRs in Contributing (#1932) meta: Add sut to contributing (#1931)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
iOS13 sample shares files with iOS Swift Sample. Sometimes we add files to one without adding it to the other preventing it from compiling.
#skip-changelog