-
-
Notifications
You must be signed in to change notification settings - Fork 306
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add a new enableAutoBreadcrumbTracking option #1958
Conversation
`Instructions and example for changelog`$
To the changelog entry, please add a link to this PR (consider a more descriptive message):` - Add a new enableAutoBreadcrumbTracking option(#1958)
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Only a few missing tests. Thanks 馃憣
@@ -19,6 +22,13 @@ @implementation SentryAutoBreadcrumbTrackingIntegration | |||
|
|||
- (void)installWithOptions:(nonnull SentryOptions *)options | |||
{ | |||
if (!options.enableAutoBreadcrumbTracking) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
m
: Please add a test for this new functionality.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's still a draft PR 馃槄
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, but I didn't see anything apart from the missing tests, so I added a comment to not forget about it.
Co-authored-by: Philipp Hofmann <philipp.hofmann@sentry.io>
Do we need to update any docs for this? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks 馃檹
馃摐 Description
We're unifying the options, so breadcrumb tracking is also enabled via a boolean option
enableAutoBreadcrumbTracking
.馃挕 Motivation and Context
Closes #427.
馃挌 How did you test it?
Unit test, also sample app.
馃摑 Checklist
馃敭 Next steps