Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: read free_memory when the event is captured, not only at SDK startup #1962

Merged
merged 14 commits into from
Jul 18, 2022
Merged

fix: read free_memory when the event is captured, not only at SDK startup #1962

Changes from 1 commit
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
b352c5b
fix: read free_memory when the event is captured, not only at SDK sta…
kevinrenskers Jul 12, 2022
67a225c
Changelog
kevinrenskers Jul 12, 2022
2f321ef
Update Sources/Sentry/SentryClient.m
kevinrenskers Jul 13, 2022
56c19a7
Merge branch 'master' into fix/1824-read-free-memory-at-time-of-event
kevinrenskers Jul 13, 2022
4336949
Change import
kevinrenskers Jul 13, 2022
2b53bbd
DRY
kevinrenskers Jul 13, 2022
f05bd6f
Merge branch 'master' into fix/1824-read-free-memory-at-time-of-event
kevinrenskers Jul 13, 2022
628dd39
Don't fetch all system info just to get the free memory
kevinrenskers Jul 13, 2022
b237658
Remove unused import
kevinrenskers Jul 13, 2022
588bd6d
Add testCaptureCrash_FreeMemory
kevinrenskers Jul 14, 2022
72d4a8b
Strengthen test via injection
kevinrenskers Jul 14, 2022
a48bdba
Merge branch 'master' into fix/1824-read-free-memory-at-time-of-event
kevinrenskers Jul 14, 2022
9c507a8
Move changelog entry
kevinrenskers Jul 15, 2022
a114f78
Merge branch 'master' into fix/1824-read-free-memory-at-time-of-event
brustolin Jul 18, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
23 changes: 23 additions & 0 deletions Tests/SentryTests/SentryClientTests.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -497,6 +497,29 @@ class SentryClientTest: XCTestCase {
}
}

func testCaptureCrash_FreeMemory() {
var freeMemory = 0
let event = TestData.event
event.threads = nil
event.debugMeta = nil

fixture.getSut().captureCrash(event, with: fixture.scope)

assertLastSentEventWithAttachment { actual in
let eventFreeMemory = actual.context?["device"]?["free_memory"] as? Int
XCTAssertNotNil(eventFreeMemory)
freeMemory = eventFreeMemory ?? 0
}

fixture.getSut().captureCrash(event, with: fixture.scope)

assertLastSentEventWithAttachment { actual in
let eventFreeMemory = actual.context?["device"]?["free_memory"] as? Int
XCTAssertNotNil(eventFreeMemory)
XCTAssertNotEqual(freeMemory, eventFreeMemory)
brustolin marked this conversation as resolved.
Show resolved Hide resolved
}
}

func testCaptureErrorWithUserInfo() {
let expectedValue = "val"
let error = NSError(domain: "domain", code: 0, userInfo: ["key": expectedValue])
Expand Down