Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: update some docs/comments to read a little better #1966

Merged
merged 2 commits into from
Jul 14, 2022
Merged

docs: update some docs/comments to read a little better #1966

merged 2 commits into from
Jul 14, 2022

Conversation

armcknight
Copy link
Member

#skip-changelog

@armcknight armcknight marked this pull request as ready for review July 13, 2022 19:43
philipphofmann
philipphofmann approved these changes Jul 14, 2022
View reviewed changes
Copy link
Member

@philipphofmann philipphofmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @armcknight 💯

@philipphofmann philipphofmann merged commit c46f1a6 into master Jul 14, 2022
@philipphofmann philipphofmann deleted the armcknight/docs-improvements branch July 14, 2022 06:35
kevinrenskers added a commit that referenced this pull request Jul 14, 2022
@kevinrenskers
Merge branch 'master' into fix/1824-read-free-memory-at-time-of-event
a48bdba 
* master:
  ci: Don't run benchmarks on release (#1971)
  Don't track OOMs for simulators (#1970)
  feat: Automatic nest new spans with the ui life cycle function (#1959)
  docs: update some docs/comments to read a little better (#1966)
  ci: benchmarking updates (#1926)
  feat: upload list of slow/frozen rendered frame timestamps during a profile (#1910)
  feat: Enhance the UIViewController breadcrumbs with more data (#1945)

# Conflicts:
#	Sources/SentryCrash/Recording/Monitors/SentryCrashMonitor_System.h
kevinrenskers added a commit that referenced this pull request Jul 18, 2022
@kevinrenskers
Merge branch 'master' into perf/1096-cache-debug-images
3e6ca07 
* master:
  ref: Fix linter error (#1981)
  fix: read free_memory when the event is captured, not only at SDK startup (#1962)
  fix: Remove Sentry keys from cached HTTP request headers (#1975)
  release: 7.21.0
  ci: Don't run benchmarks on release (#1971)
  Don't track OOMs for simulators (#1970)
  feat: Automatic nest new spans with the ui life cycle function (#1959)
  docs: update some docs/comments to read a little better (#1966)
  ci: benchmarking updates (#1926)
  feat: upload list of slow/frozen rendered frame timestamps during a profile (#1910)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@philipphofmann philipphofmann philipphofmann approved these changes

@brustolin brustolin Awaiting requested review from brustolin

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@armcknight @philipphofmann @getsentry-bot