ci: benchmarking and profile generation improvements

[armcknight]

• The profile generation workflow is flaking a lot. This simplifies the test logic and makes more granular XCUIElementQueries so we can better pinpoint failures.
  • There seem to be two failure modes happening:
    1. Can't find back button when it thinks it's in a movie detail view but it's actually already back on the movie list.
       • ✅ In this case, when it doesn't find a back button, we check if the tab bar is visible to verify if we're already back on the list.
    2. Can't find the back button when it goes to a movie detail and the app crashes. Seems to always happen right after navigating to the last tab bar button item.
       • ❌ tried converting all fatalErrors to print statements
       • ❌ tried disabling automatic UIControl tracing, since we define our own spans
       • ❌ try fixing some possible nil dereferences uncovered by thread sanitizer
       • ❌ retry everything 5 times with saucectl
       • ➡️ we just won't generate profiles from low-end devices, it's the only one that consistently fails
• Fixes a bug where the TrendingMovies carthage dependencies are rebuilt even with cache hits. Takes job time from 13 down to 4.5 minutes.
• Don't upload dSYMs for profile generation test runner app; we only need one for the app under test it's driving.
• Standardize on using one device from each class we have (recently updated in fix: update ios device classification sentry#37044)
  • Try twiddling some things to get the low-end device to pass–it consistently fails to start the test process.
• Assert benchmark overhead result is > 0%; this started happening due to some bug and the test happily passed since it's < 5%.
• After changing the benchmark to start directly when the performance VC is presented, in combination with the new option to automatically track VC performance, the profiler would stop soon after beginning due to the idle timeout. disabled auto tracing to prevent this behavior (this happened before with the button press to start the benchmark in combination with enableUserInteractionTracing)
• Fixed another edge case in the benchmark report generation script for various ways xcuitest log lines are exported with newlines and escaped newlines

#skip-changelog

[indragiek]

I remember hitting a crash here earlier, thanks for fixing this