Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Making Hybrid SDK only header private for everybody else #2458

Merged
merged 10 commits into from Nov 30, 2022

Conversation

brustolin
Copy link
Contributor

Exposing some headers to hybridSDK only.
closes #2452

#skip-changelog

@github-actions
Copy link

github-actions bot commented Nov 29, 2022

Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1251.20 ms 1276.46 ms 25.26 ms
Size 20.75 KiB 383.38 KiB 362.63 KiB

Baseline results on branch: 8.0.0

Startup times

Revision Plain With Sentry Diff
e2cec76 1189.48 ms 1229.84 ms 40.36 ms
68094b3 1214.14 ms 1255.09 ms 40.95 ms
9f8d429 1239.57 ms 1255.12 ms 15.55 ms
9cb6c52 1201.08 ms 1211.37 ms 10.29 ms
3fdb749 1227.42 ms 1248.48 ms 21.06 ms
c9129b6 1231.86 ms 1270.11 ms 38.25 ms
d10145a 1232.65 ms 1257.55 ms 24.90 ms
1ce879f 1258.12 ms 1260.90 ms 2.78 ms
909e73a 1217.78 ms 1229.70 ms 11.92 ms
dcac8ad 1238.82 ms 1247.80 ms 8.98 ms

App size

Revision Plain With Sentry Diff
e2cec76 20.75 KiB 381.81 KiB 361.06 KiB
68094b3 20.75 KiB 373.94 KiB 353.19 KiB
9f8d429 20.75 KiB 383.40 KiB 362.65 KiB
9cb6c52 20.75 KiB 382.12 KiB 361.36 KiB
3fdb749 20.75 KiB 383.81 KiB 363.06 KiB
c9129b6 20.75 KiB 381.81 KiB 361.06 KiB
d10145a 20.75 KiB 379.12 KiB 358.36 KiB
1ce879f 20.75 KiB 381.81 KiB 361.06 KiB
909e73a 20.75 KiB 383.40 KiB 362.65 KiB
dcac8ad 20.75 KiB 379.11 KiB 358.36 KiB

Copy link
Member

@philipphofmann philipphofmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🙏

@brustolin brustolin merged commit 7f1b08e into 8.0.0 Nov 30, 2022
@brustolin brustolin deleted the chore/move-headers branch November 30, 2022 14:53
philipphofmann added a commit that referenced this pull request Jan 2, 2024
SentryAppStartMeasurement is only plublic for hybrid SDKs since
#2458. Therefore, we can
remove the deprecated init method.
philipphofmann added a commit that referenced this pull request Jan 3, 2024
SentryAppStartMeasurement is only plublic for hybrid SDKs since
#2458. Therefore, we can
remove the deprecated init method.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants