ci: only archive derived data logs if the build step fails #3011
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #3011 +/- ##
=============================================
+ Coverage 88.307% 88.315% +0.007%
=============================================
Files 495 495
Lines 53230 53232 +2
Branches 19114 19113 -1
=============================================
+ Hits 47006 47012 +6
Misses 5256 5256
+ Partials 968 964 -4 see 13 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
|
Well, got a natural experiment with a flake, at least the changes are validated 😆 https://github.com/getsentry/sentry-cocoa/actions/runs/4915463064/jobs/8778134993?pr=3011 |
brustolin
approved these changes
May 8, 2023
armcknight
deleted the
armcknight/ci/archive-deriveddata-logs-only-on-build-failure
branch
armcknight
added a commit
that referenced
this pull request
May 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed a case where it took several minutes to archive derived data logs here:
This happened due to a test failure. Now that we've split up the build and runtest steps, I think we only need derived data logs if the build step fails. Once the build succeeds, these logs can't help for test run failures, so the step linked above didn't actually need to run.
#skip-changelog