Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Fix skipping codecov2 upload for scheduled #3015

Merged
merged 1 commit into from
May 9, 2023

Conversation

philipphofmann
Copy link
Member

Scheduled runs try to upload coverage. I guess that's because the ${{ wasn't put at the beginning of the if statement in the yml.

https://github.com/getsentry/sentry-cocoa/actions/runs/4922793243/jobs/8793926172

@codecov
Copy link

codecov bot commented May 9, 2023

Codecov Report

Merging #3015 (00d74cb) into main (ba4d16f) will decrease coverage by 0.370%.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff              @@
##              main     #3015       +/-   ##
=============================================
- Coverage   88.624%   88.254%   -0.370%     
=============================================
  Files          495       495               
  Lines        56760     53256     -3504     
  Branches     19243     19129      -114     
=============================================
- Hits         50303     47001     -3302     
+ Misses        5617      5285      -332     
- Partials       840       970      +130     

see 247 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ba4d16f...00d74cb. Read the comment docs.

@philipphofmann philipphofmann merged commit 8a219cb into main May 9, 2023
24 of 25 checks passed
@philipphofmann philipphofmann deleted the ci/skip-codecov2-upload-for-scheduled2 branch May 9, 2023 07:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants