-
-
Notifications
You must be signed in to change notification settings - Fork 313
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Remove remaining fishhook code #3020
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #3020 +/- ##
=============================================
+ Coverage 88.270% 88.842% +0.571%
=============================================
Files 495 492 -3
Lines 53251 52887 -364
Branches 19130 18970 -160
=============================================
- Hits 47005 46986 -19
+ Misses 5281 4944 -337
+ Partials 965 957 -8
... and 8 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
Performance metrics 🚀
|
Revision | Plain | With Sentry | Diff |
---|---|---|---|
8f397a7 | 1251.82 ms | 1268.34 ms | 16.52 ms |
dacf894 | 1232.32 ms | 1236.34 ms | 4.02 ms |
3f1be0f | 1208.12 ms | 1225.72 ms | 17.60 ms |
c021422 | 1237.12 ms | 1263.18 ms | 26.06 ms |
034be1c | 1222.67 ms | 1236.22 ms | 13.55 ms |
ad7cec6 | 1203.22 ms | 1224.74 ms | 21.52 ms |
d3edf46 | 1213.00 ms | 1227.46 ms | 14.46 ms |
621ba9b | 1190.66 ms | 1230.84 ms | 40.18 ms |
7bc3c0d | 1261.16 ms | 1278.38 ms | 17.22 ms |
ba4d16f | 1236.90 ms | 1252.12 ms | 15.22 ms |
App size
Revision | Plain | With Sentry | Diff |
---|---|---|---|
8f397a7 | 20.76 KiB | 420.55 KiB | 399.79 KiB |
dacf894 | 20.76 KiB | 426.34 KiB | 405.58 KiB |
3f1be0f | 20.76 KiB | 414.44 KiB | 393.69 KiB |
c021422 | 20.76 KiB | 435.64 KiB | 414.88 KiB |
034be1c | 20.76 KiB | 436.66 KiB | 415.90 KiB |
ad7cec6 | 20.76 KiB | 427.32 KiB | 406.55 KiB |
d3edf46 | 20.76 KiB | 436.65 KiB | 415.89 KiB |
621ba9b | 20.76 KiB | 414.45 KiB | 393.69 KiB |
7bc3c0d | 20.76 KiB | 427.36 KiB | 406.59 KiB |
ba4d16f | 20.76 KiB | 437.12 KiB | 416.36 KiB |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ups, LGTM
Removed the remaining async stitch code.
#skip-changelog