Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: BUILD_LIBRARY_FOR_DISTRIBUTION in Makefile #3488

Merged
merged 3 commits into from Jan 8, 2024

Conversation

akoeplinger
Copy link
Contributor

馃摐 Description

The variable is called BUILD_LIBRARY_FOR_DISTRIBUTION (singular) not BUILD_LIBRARIES_FOR_DISTRIBUTION (plural):

馃挕 Motivation and Context

This seems to be a common typo that is unfortunately spread across various blog posts.

馃挌 How did you test it?

馃摑 Checklist

You have to check all boxes before merging:

  • I reviewed the submitted code.
  • I added tests to verify the changes.
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled.
  • I updated the docs if needed.
  • Review from the native team if needed.
  • No breaking change or entry added to the changelog.
  • No breaking change for hybrid SDKs or communicated to hybrid SDKs.

馃敭 Next steps

The variable is called `BUILD_LIBRARY_FOR_DISTRIBUTION` (singular) not `BUILD_LIBRARIES_FOR_DISTRIBUTION` (plural: https://developer.apple.com/documentation/xcode/build-settings-reference#Build-Libraries-for-Distribution

This seems to be a common typo that is unfortunately spread across various blog posts.
@akoeplinger akoeplinger changed the title Fix BUILD_LIBRARY_FOR_DISTRIBUTION in Makefile fix: BUILD_LIBRARY_FOR_DISTRIBUTION in Makefile Dec 7, 2023
Copy link
Member

@armcknight armcknight left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution @akoeplinger! That is indeed a very unfortunate typo being spread around, and an unfortunate naming discrepancy even in Xcode
image
image

@philipphofmann
Copy link
Member

@armcknight, can we merge this? If yes, please smash that button 馃槃.

@armcknight armcknight merged commit 02e1163 into getsentry:main Jan 8, 2024
2 checks passed
@akoeplinger akoeplinger deleted the patch-1 branch January 9, 2024 14:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants