New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add frames delay to span data #3496
Conversation
Also fix a couple of edge cases when calculating the frames delay when an ongoing delayed frame is not yet recorded.
|
Performance metrics 馃殌
|
Revision | Plain | With Sentry | Diff |
---|---|---|---|
b064665 | 1230.04 ms | 1254.08 ms | 24.04 ms |
ddc9b9a | 1210.00 ms | 1234.18 ms | 24.18 ms |
50bbebb | 1234.76 ms | 1246.66 ms | 11.90 ms |
2154ae1 | 1216.06 ms | 1244.78 ms | 28.72 ms |
e7b566f | 1199.57 ms | 1218.76 ms | 19.19 ms |
fb53d97 | 1226.08 ms | 1245.12 ms | 19.04 ms |
e8b11f8 | 1233.66 ms | 1249.74 ms | 16.08 ms |
881a955 | 1230.69 ms | 1244.12 ms | 13.43 ms |
3437454 | 1254.04 ms | 1259.50 ms | 5.46 ms |
5ab598f | 1213.90 ms | 1240.45 ms | 26.55 ms |
App size
Revision | Plain | With Sentry | Diff |
---|---|---|---|
b064665 | 22.85 KiB | 413.42 KiB | 390.57 KiB |
ddc9b9a | 20.76 KiB | 420.40 KiB | 399.64 KiB |
50bbebb | 21.58 KiB | 414.96 KiB | 393.38 KiB |
2154ae1 | 20.76 KiB | 427.83 KiB | 407.06 KiB |
e7b566f | 22.85 KiB | 414.80 KiB | 391.95 KiB |
fb53d97 | 20.76 KiB | 425.81 KiB | 405.04 KiB |
e8b11f8 | 22.85 KiB | 411.92 KiB | 389.07 KiB |
881a955 | 22.85 KiB | 407.63 KiB | 384.78 KiB |
3437454 | 22.85 KiB | 408.87 KiB | 386.02 KiB |
5ab598f | 22.84 KiB | 403.17 KiB | 380.33 KiB |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #3496 +/- ##
=============================================
+ Coverage 89.163% 89.178% +0.014%
=============================================
Files 528 528
Lines 57224 57441 +217
Branches 20260 20579 +319
=============================================
+ Hits 51023 51225 +202
- Misses 5286 5297 +11
- Partials 915 919 +4
... and 66 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
馃摐 Description
Also fix a couple of edge cases when calculating the frames delay when an ongoing delayed frame is not yet recorded.
馃挕 Motivation and Context
Fixes GH-3481
馃挌 How did you test it?
Unit tests and with the simulator
馃摑 Checklist
You have to check all boxes before merging:
sendDefaultPII
is enabled.馃敭 Next steps
Update the docs once we show the feature in mobile starfish.