Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ref: Add DispatchQueue property #3497

Conversation

philipphofmann
Copy link
Member

@philipphofmann philipphofmann commented Dec 14, 2023

Copy link

codecov bot commented Dec 14, 2023

Codecov Report

Merging #3497 (5cf62fc) into armcknight/fix/3476-unscheduled-deadline-timer (d78ee13) will decrease coverage by 0.014%.
The diff coverage is 100.000%.

Additional details and impacted files

Impacted file tree graph

@@                                 Coverage Diff                                  @@
##           armcknight/fix/3476-unscheduled-deadline-timer     #3497       +/-   ##
====================================================================================
- Coverage                                          88.974%   88.961%   -0.014%     
====================================================================================
  Files                                                 525       525               
  Lines                                               56733     56619      -114     
  Branches                                            20407     20379       -28     
====================================================================================
- Hits                                                50478     50369      -109     
+ Misses                                               5332      5215      -117     
- Partials                                              923      1035      +112     
Files Coverage Δ
Sources/Sentry/SentryTracer.m 96.812% <100.000%> (+0.172%) ⬆️

... and 35 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d78ee13...5cf62fc. Read the comment docs.

Copy link

Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1196.41 ms 1207.92 ms 11.51 ms
Size 21.58 KiB 413.99 KiB 392.41 KiB

Baseline results on branch: armcknight/fix/3476-unscheduled-deadline-timer

Startup times

Revision Plain With Sentry Diff
123eec4 1223.96 ms 1235.18 ms 11.22 ms

App size

Revision Plain With Sentry Diff
123eec4 21.58 KiB 414.52 KiB 392.94 KiB

Copy link
Contributor

@brustolin brustolin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@armcknight armcknight left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see what you mean, yeah that makes things a little more concise.

@armcknight armcknight merged commit f38656b into armcknight/fix/3476-unscheduled-deadline-timer Dec 18, 2023
65 of 69 checks passed
@armcknight armcknight deleted the ref/dispatch-queue-property branch December 18, 2023 19:33
armcknight pushed a commit that referenced this pull request Jan 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants