Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: sample app and ui test tweaks #3542

Merged
merged 4 commits into from
Jan 8, 2024

Conversation

armcknight
Copy link
Member

@armcknight armcknight commented Jan 5, 2024

  • delete Samples/iOS-Swift/ClearTestState.swift as it isn't used
  • remove SentryBenchmarking.mm from compiling into iOS-SwiftUITests as it's only needed in the actual test harness (iOS-Swift app), not the test runner
  • remove SentryDevice.mm from compiling into iOS-Swift, as it's only needed in the test runner (iOS-SwiftUITests)
  • add launch args to iOS-Swift to allow parameterizing trace and profile sample rates set via either numerical rate or sampling function (this will help with some UI tests that are coming in feat(app launch profiling): add app launch profiling #3529 )
  • some changes Xcode automatically made to tvOS-Swift.xcodeproj involving linking some dependencies like SentryPrivate, SentryTestUtils, etc
  • remove scripts/set-device-tests-environment.patch and do the configuration directly in AppDelegate; this has caused merge conflicts a few times when i modify something in AppDelegate and causes CI to break

#skip-changelog

Copy link

codecov bot commented Jan 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (1734d1b) 89.241% compared to head (b6afade) 89.261%.

Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff              @@
##              main     #3542       +/-   ##
=============================================
+ Coverage   89.241%   89.261%   +0.019%     
=============================================
  Files          529       529               
  Lines        57780     57794       +14     
  Branches     20687     20691        +4     
=============================================
+ Hits         51564     51588       +24     
+ Misses        5300      5296        -4     
+ Partials       916       910        -6     

see 12 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1734d1b...b6afade. Read the comment docs.

Copy link

github-actions bot commented Jan 5, 2024

Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1229.24 ms 1247.61 ms 18.37 ms
Size 21.58 KiB 418.82 KiB 397.24 KiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
c0ff306 1219.24 ms 1243.96 ms 24.72 ms
9883c0f 1207.59 ms 1223.14 ms 15.55 ms
313b1d9 1240.18 ms 1258.44 ms 18.26 ms
034be1c 1222.67 ms 1236.22 ms 13.55 ms
156e771 1228.06 ms 1242.64 ms 14.58 ms
e2abb0d 1235.08 ms 1257.00 ms 21.92 ms
216bdf9 1199.84 ms 1209.53 ms 9.69 ms
b9a9ffd 1221.18 ms 1235.37 ms 14.19 ms
a9103fe 1221.49 ms 1243.33 ms 21.84 ms
3f6c30b 1252.98 ms 1266.22 ms 13.24 ms

App size

Revision Plain With Sentry Diff
c0ff306 20.76 KiB 434.65 KiB 413.89 KiB
9883c0f 22.85 KiB 405.47 KiB 382.62 KiB
313b1d9 22.85 KiB 414.11 KiB 391.26 KiB
034be1c 20.76 KiB 436.66 KiB 415.90 KiB
156e771 20.76 KiB 419.70 KiB 398.94 KiB
e2abb0d 20.76 KiB 434.72 KiB 413.96 KiB
216bdf9 21.58 KiB 418.13 KiB 396.54 KiB
b9a9ffd 21.58 KiB 418.43 KiB 396.85 KiB
a9103fe 20.76 KiB 426.95 KiB 406.19 KiB
3f6c30b 22.85 KiB 408.88 KiB 386.03 KiB

Previous results on branch: armcknight/test/sample-app-tweaks

Startup times

Revision Plain With Sentry Diff
c258474 1201.71 ms 1211.61 ms 9.90 ms

App size

Revision Plain With Sentry Diff
c258474 21.58 KiB 418.82 KiB 397.24 KiB

Copy link
Contributor

@brustolin brustolin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@philipphofmann philipphofmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome thanks 💯

@armcknight armcknight merged commit 5e3084f into main Jan 8, 2024
70 checks passed
@armcknight armcknight deleted the armcknight/test/sample-app-tweaks branch January 8, 2024 20:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants