New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(metrics): Add timing API #3812
Conversation
Add the timing API to measure the duration of a closure.
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3812 +/- ##
=============================================
- Coverage 90.947% 90.890% -0.058%
=============================================
Files 560 560
Lines 44186 44281 +95
Branches 15764 15812 +48
=============================================
+ Hits 40186 40247 +61
+ Misses 3930 3854 -76
- Partials 70 180 +110
... and 32 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
Performance metrics 馃殌
|
Revision | Plain | With Sentry | Diff |
---|---|---|---|
e84bc3f | 1257.08 ms | 1267.41 ms | 10.33 ms |
e1cd9e9 | 1203.93 ms | 1239.12 ms | 35.19 ms |
32e64d1 | 1224.45 ms | 1238.94 ms | 14.49 ms |
be2977c | 1202.51 ms | 1221.32 ms | 18.81 ms |
8c8654d | 1214.43 ms | 1223.88 ms | 9.45 ms |
db533ee | 1228.96 ms | 1248.23 ms | 19.28 ms |
3f366ee | 1242.28 ms | 1260.80 ms | 18.52 ms |
4654f66 | 1247.16 ms | 1263.96 ms | 16.80 ms |
189b629 | 1250.64 ms | 1261.02 ms | 10.38 ms |
d10ae0c | 1250.02 ms | 1253.74 ms | 3.72 ms |
App size
Revision | Plain | With Sentry | Diff |
---|---|---|---|
e84bc3f | 20.76 KiB | 434.72 KiB | 413.96 KiB |
e1cd9e9 | 22.85 KiB | 412.95 KiB | 390.10 KiB |
32e64d1 | 20.76 KiB | 433.18 KiB | 412.42 KiB |
be2977c | 22.85 KiB | 407.67 KiB | 384.83 KiB |
8c8654d | 22.84 KiB | 403.18 KiB | 380.33 KiB |
db533ee | 21.58 KiB | 547.02 KiB | 525.44 KiB |
3f366ee | 20.76 KiB | 427.84 KiB | 407.08 KiB |
4654f66 | 20.76 KiB | 432.17 KiB | 411.41 KiB |
189b629 | 20.76 KiB | 399.69 KiB | 378.93 KiB |
d10ae0c | 20.76 KiB | 419.86 KiB | 399.10 KiB |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
馃摐 Description
Add the timing API to measure the duration of a closure.
馃挕 Motivation and Context
Part of #3790.
馃挌 How did you test it?
Unit tests and with a simulator. Here is an example in Sentry https://sentry-sdks.sentry.io/performance/sentry-cocoa:94a719e3ebbe444fac10279e60795f3c/#span-0af24f27f2674bef.
馃摑 Checklist
You have to check all boxes before merging:
sendDefaultPII
is enabled.馃敭 Next steps