New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: SentrySwiftUI Carthage build import #3817
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3817 +/- ##
=============================================
+ Coverage 90.877% 90.881% +0.004%
=============================================
Files 559 559
Lines 44054 44054
Branches 15701 15692 -9
=============================================
+ Hits 40035 40037 +2
+ Misses 3949 3838 -111
- Partials 70 179 +109 see 29 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
a8c981d
to
3dfe364
Compare
3dfe364
to
1a3e4cc
Compare
Hello @nekrich, thanks for the help with this PR!! |
…try-cocoa into fix/swiftui-carthage
📜 Description
tl;dr; Fixed SentrySwiftUI Carthage build import.
Since there is no modulemap for the SentrySwiftUI declaring exported submodules:
@_implementationOnly import SentryInternal
.💡 Motivation and Context
Can't import prebuild SentrySwiftUI.xcframework. Got a
No such module 'SentryInternal'
error.🖼️ Screenshot
💚 How did you test it?
make build-xcframework
to create xcframework.📝 Checklist
You have to check all boxes before merging:
sendDefaultPII
is enabled.🔮 Next steps