Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: SentrySwiftUI Carthage build import #3817

Merged
merged 10 commits into from Apr 3, 2024

Conversation

nekrich
Copy link
Contributor

@nekrich nekrich commented Apr 2, 2024

📜 Description

tl;dr; Fixed SentrySwiftUI Carthage build import.

Since there is no modulemap for the SentrySwiftUI declaring exported submodules:

  1. For Carthage build make @_implementationOnly import SentryInternal.
  2. Import SentrySwiftUI xcframework Samples/Carthage-Validation/XCFramework project to check imports.

💡 Motivation and Context

Can't import prebuild SentrySwiftUI.xcframework. Got a No such module 'SentryInternal' error.

🖼️ Screenshot image
At first I thought it's library evolution again, but it was broken imports inside a private swift interface file.

💚 How did you test it?

  1. Run make build-xcframework to create xcframework.
  2. Import SentrySwiftUI.xcframework into a Samples/Carthage-Validation/XCFramework project.
  3. Build Samples/Carthage-Validation/XCFramework project.

📝 Checklist

You have to check all boxes before merging:

  • I reviewed the submitted code.
  • I added tests to verify the changes.
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled.
  • I updated the docs if needed.
  • Review from the native team if needed.
  • No breaking change or entry added to the changelog.
  • No breaking change for hybrid SDKs or communicated to hybrid SDKs.

🔮 Next steps

Copy link

codecov bot commented Apr 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.881%. Comparing base (1ee3d54) to head (39d4610).

Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff              @@
##              main     #3817       +/-   ##
=============================================
+ Coverage   90.877%   90.881%   +0.004%     
=============================================
  Files          559       559               
  Lines        44054     44054               
  Branches     15701     15692        -9     
=============================================
+ Hits         40035     40037        +2     
+ Misses        3949      3838      -111     
- Partials        70       179      +109     

see 29 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1ee3d54...39d4610. Read the comment docs.

@brustolin
Copy link
Contributor

Hello @nekrich, thanks for the help with this PR!!

@brustolin brustolin merged commit fddeb9e into getsentry:main Apr 3, 2024
64 of 67 checks passed
@nekrich nekrich deleted the fix/swiftui-carthage branch April 3, 2024 11:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants