fix: InvalidArgException for sentryErrorWithDomain

[philipphofmann]

📜 Description

Fix NSInvalidArgumentException for NSError sentryErrorWithDomain by removing the category functions because they get stripped for static libraries. This is related to GH-3764.

💡 Motivation and Context

Fixes GH-3818

💚 How did you test it?

Same problem as #3763, for which removing the category function worked. So no need for an extra test.

📝 Checklist

You have to check all boxes before merging:

• I reviewed the submitted code.
• I added tests to verify the changes.
• No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled.
• I updated the docs if needed.
• Review from the native team if needed.
• No breaking change or entry added to the changelog.
• No breaking change for hybrid SDKs or communicated to hybrid SDKs.

🔮 Next steps

[codecov]

Codecov Report

Attention: Patch coverage is 59.37500% with 13 lines in your changes are missing coverage. Please review.

Project coverage is 91.013%. Comparing base (408f43e) to head (3892d0b).

Additional details and impacted files

@@              Coverage Diff              @@
##              main     #3819       +/-   ##
=============================================
- Coverage   91.046%   91.013%   -0.033%     
=============================================
  Files          560       560               
  Lines        44506     44455       -51     
  Branches     15770     15773        +3     
=============================================
- Hits         40521     40460       -61     
+ Misses        3915      3818       -97     
- Partials        70       177      +107     

Files	Coverage Δ
...ntryCrash/Recording/Tools/SentryCrashNSErrorUtil.m	100.000% <100.000%> (ø)
...tryTests/SentryCrash/SentryCrashNSErrorUtilTests.m	100.000% <100.000%> (ø)
...yTests/SentryCrash/SentryCrashReportFilter_Tests.m	95.811% <ø> (ø)
Sources/SentryCrash/Recording/SentryCrash.m	81.938% <0.000%> (+0.359%)	⬆️
...h/Reporting/Filters/SentryCrashReportFilterBasic.m	95.022% <83.333%> (+0.285%)	⬆️
...ryCrash/Recording/Tools/SentryCrashJSONCodecObjC.m	92.817% <60.000%> (+1.812%)	⬆️
...entryCrash/Installations/SentryCrashInstallation.m	34.210% <0.000%> (+0.877%)	⬆️

... and 28 files with indirect coverage changes

---

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 408f43e...3892d0b. Read the comment docs.

[brustolin]

Thanks!!

[github-actions]

Performance metrics 🚀

	Plain	With Sentry	Diff
Startup time	1202.36 ms	1225.41 ms	23.05 ms
Size	21.58 KiB	572.91 KiB	551.33 KiB

Baseline results on branch: main

Startup times

Revision	Plain	With Sentry	Diff
bfa3487	1194.19 ms	1224.20 ms	30.01 ms
d3edf46	1213.00 ms	1227.46 ms	14.46 ms
5616e0a	1237.00 ms	1260.43 ms	23.43 ms
7c5d161	1224.38 ms	1249.66 ms	25.28 ms
a2af9fa	1236.29 ms	1251.67 ms	15.38 ms
0776564	1224.35 ms	1247.26 ms	22.91 ms
408f43e	1229.31 ms	1247.52 ms	18.21 ms
ecd9ecd	1215.77 ms	1238.70 ms	22.93 ms
6001822	1233.31 ms	1251.64 ms	18.33 ms
9cc7e7c	1228.90 ms	1237.96 ms	9.06 ms

App size

Revision	Plain	With Sentry	Diff
bfa3487	20.76 KiB	393.36 KiB	372.60 KiB
d3edf46	20.76 KiB	436.65 KiB	415.89 KiB
5616e0a	22.85 KiB	407.45 KiB	384.60 KiB
7c5d161	20.76 KiB	414.44 KiB	393.68 KiB
a2af9fa	20.76 KiB	432.88 KiB	412.11 KiB
0776564	20.76 KiB	399.19 KiB	378.43 KiB
408f43e	21.58 KiB	573.17 KiB	551.59 KiB
ecd9ecd	20.76 KiB	420.23 KiB	399.47 KiB
6001822	22.85 KiB	410.99 KiB	388.14 KiB
9cc7e7c	22.84 KiB	403.13 KiB	380.29 KiB