New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(replay): add Hybrid SDKs Replay interface #3879
Conversation
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3879 +/- ##
=============================================
- Coverage 90.635% 90.586% -0.050%
=============================================
Files 579 581 +2
Lines 45298 45349 +51
Branches 16122 16148 +26
=============================================
+ Hits 41056 41080 +24
- Misses 4063 4199 +136
+ Partials 179 70 -109
... and 41 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
…dks-replay-interface
Performance metrics 🚀
|
Revision | Plain | With Sentry | Diff |
---|---|---|---|
06548c0 | 1225.58 ms | 1244.70 ms | 19.12 ms |
4259afd | 1222.12 ms | 1249.74 ms | 27.62 ms |
189b629 | 1211.16 ms | 1224.30 ms | 13.14 ms |
af1f4dd | 1232.39 ms | 1255.88 ms | 23.49 ms |
89bc37d | 1228.20 ms | 1257.10 ms | 28.90 ms |
50bb751 | 1230.94 ms | 1238.69 ms | 7.75 ms |
a423161 | 1234.41 ms | 1246.41 ms | 12.00 ms |
39b1c35 | 1236.35 ms | 1239.90 ms | 3.55 ms |
28333b6 | 1186.29 ms | 1225.18 ms | 38.89 ms |
ca91a5c | 1234.53 ms | 1249.86 ms | 15.33 ms |
App size
Revision | Plain | With Sentry | Diff |
---|---|---|---|
06548c0 | 20.76 KiB | 427.35 KiB | 406.59 KiB |
4259afd | 20.76 KiB | 419.70 KiB | 398.94 KiB |
189b629 | 20.76 KiB | 399.69 KiB | 378.93 KiB |
af1f4dd | 22.85 KiB | 414.71 KiB | 391.86 KiB |
89bc37d | 20.76 KiB | 401.53 KiB | 380.77 KiB |
50bb751 | 21.58 KiB | 417.86 KiB | 396.27 KiB |
a423161 | 22.85 KiB | 406.69 KiB | 383.85 KiB |
39b1c35 | 22.85 KiB | 408.88 KiB | 386.03 KiB |
28333b6 | 20.76 KiB | 424.69 KiB | 403.93 KiB |
ca91a5c | 22.84 KiB | 403.19 KiB | 380.34 KiB |
Previous results on branch: kw-add-hybrid-sdks-replay-interface
Startup times
Revision | Plain | With Sentry | Diff |
---|---|---|---|
85acf3b | 1234.26 ms | 1250.88 ms | 16.62 ms |
54ce03c | 1232.27 ms | 1258.22 ms | 25.96 ms |
App size
Revision | Plain | With Sentry | Diff |
---|---|---|---|
85acf3b | 21.58 KiB | 615.52 KiB | 593.94 KiB |
54ce03c | 21.58 KiB | 615.52 KiB | 593.93 KiB |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I reviewed this in real life! It looks good!
The #3878 needs to be merged first. As this PR uses the new captureReplay method. |
This PR adds a simple
captureReplay
interface hiding implementation details from the Hybrid SDKs.This PR is need for the
alpha.0
of RN replay.#skip-changelog