-
-
Notifications
You must be signed in to change notification settings - Fork 307
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Handle no releaseName in WatchdogLogic #3919
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The release name passed to the app state from the options is nullable. The SentryAppState including the SentryWatchDogTerminationLogic couldn't handle this edge case correctly, which is fixed now.
philipphofmann
changed the title
fix: Handle no releaseName in WatchDogLogic
fix: Handle no releaseName in WatchdogLogic
Apr 29, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3919 +/- ##
=============================================
+ Coverage 90.690% 90.694% +0.003%
=============================================
Files 581 582 +1
Lines 45418 45520 +102
Branches 16162 16221 +59
=============================================
+ Hits 41190 41284 +94
- Misses 4048 4166 +118
+ Partials 180 70 -110
... and 44 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
Performance metrics 🚀
|
Revision | Plain | With Sentry | Diff |
---|---|---|---|
408f43e | 1210.44 ms | 1242.35 ms | 31.91 ms |
07b120c | 1227.48 ms | 1235.14 ms | 7.66 ms |
d9308fd | 1228.04 ms | 1243.35 ms | 15.31 ms |
60dd0f5 | 1238.98 ms | 1254.48 ms | 15.50 ms |
51307b7 | 1223.08 ms | 1240.76 ms | 17.68 ms |
ee3f02e | 1236.53 ms | 1263.54 ms | 27.01 ms |
eaa1002 | 1205.50 ms | 1235.08 ms | 29.58 ms |
b9a9dca | 1196.09 ms | 1225.14 ms | 29.05 ms |
a6f8b18 | 1238.54 ms | 1265.56 ms | 27.02 ms |
28c80b5 | 1198.63 ms | 1214.08 ms | 15.45 ms |
App size
Revision | Plain | With Sentry | Diff |
---|---|---|---|
408f43e | 21.58 KiB | 573.17 KiB | 551.59 KiB |
07b120c | 21.58 KiB | 614.90 KiB | 593.32 KiB |
d9308fd | 21.58 KiB | 612.83 KiB | 591.25 KiB |
60dd0f5 | 20.76 KiB | 393.37 KiB | 372.61 KiB |
51307b7 | 22.85 KiB | 407.63 KiB | 384.78 KiB |
ee3f02e | 22.84 KiB | 401.67 KiB | 378.83 KiB |
eaa1002 | 20.76 KiB | 423.19 KiB | 402.43 KiB |
b9a9dca | 21.58 KiB | 414.59 KiB | 393.01 KiB |
a6f8b18 | 20.76 KiB | 431.87 KiB | 411.11 KiB |
28c80b5 | 21.58 KiB | 417.85 KiB | 396.27 KiB |
brustolin
approved these changes
Apr 30, 2024
philipphofmann
added a commit
that referenced
this pull request
May 6, 2024
The release name passed to the app state from the options is nullable. The SentryAppState including the SentryWatchDogTerminationLogic couldn't handle this edge case correctly, which is fixed now.
dKasabwala
pushed a commit
to dKasabwala/sentry-cocoa
that referenced
this pull request
May 6, 2024
The release name passed to the app state from the options is nullable. The SentryAppState including the SentryWatchDogTerminationLogic couldn't handle this edge case correctly, which is fixed now.
threema-matteo
pushed a commit
to threema-ch/sentry-cocoa
that referenced
this pull request
May 21, 2024
The release name passed to the app state from the options is nullable. The SentryAppState including the SentryWatchDogTerminationLogic couldn't handle this edge case correctly, which is fixed now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📜 Description
The release name passed to the app state from the options is nullable. The SentryAppState including the SentryWatchdogTerminationLogic couldn't handle this edge case correctly, which is fixed now.
💡 Motivation and Context
Unit tests started to fail suddenly on the main branch https://github.com/getsentry/sentry-cocoa/actions/runs/8879401702/job/24377229574.
💚 How did you test it?
Unit tests
📝 Checklist
You have to check all boxes before merging:
sendDefaultPII
is enabled.🔮 Next steps