Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: 'SentryFileManager+Test.h' file not found #3950

Merged
merged 2 commits into from
May 7, 2024

Conversation

brustolin
Copy link
Contributor

@brustolin brustolin commented May 7, 2024

📜 Description

The pr #3929 introduced a bug that happens when Sentry is added with cocoapod, by exposing a Test file during debug, but this file is not available for cocoapod.

image

💚 How did you test it?

Sample

📝 Checklist

You have to check all boxes before merging:

  • I reviewed the submitted code.
  • I added tests to verify the changes.
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled.
  • I updated the docs if needed.
  • Review from the native team if needed.
  • No breaking change or entry added to the changelog.
  • No breaking change for hybrid SDKs or communicated to hybrid SDKs.

🔮 Next steps

Copy link
Member

@krystofwoldrich krystofwoldrich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

Fixes getsentry/sentry-react-native#3802 (review)

Tested with the RN Repo Sample

Copy link

codecov bot commented May 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.810%. Comparing base (3c58bf9) to head (d307a37).

Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff              @@
##              main     #3950       +/-   ##
=============================================
+ Coverage   90.766%   90.810%   +0.043%     
=============================================
  Files          588       588               
  Lines        45878     45879        +1     
  Branches     16368     16353       -15     
=============================================
+ Hits         41642     41663       +21     
+ Misses        4166      4146       -20     
  Partials        70        70               
Files Coverage Δ
Sources/Sentry/SentryTracer.m 97.607% <ø> (+0.717%) ⬆️

... and 9 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3c58bf9...d307a37. Read the comment docs.

@brustolin brustolin merged commit 3be3d28 into main May 7, 2024
69 of 70 checks passed
@brustolin brustolin deleted the fiz/SentryTracer-referenceToTEst branch May 7, 2024 18:57
philipphofmann pushed a commit that referenced this pull request May 10, 2024
* Update SentryTracer.m

* Update CHANGELOG.md
threema-matteo pushed a commit to threema-ch/sentry-cocoa that referenced this pull request May 21, 2024
* Update SentryTracer.m

* Update CHANGELOG.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants