Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Convert Swift extension to helper class for use by ObjC #3973

Merged

Conversation

maxchuquimia
Copy link
Contributor

@maxchuquimia maxchuquimia commented May 13, 2024

📜 Description

Resolves a crash in #3931

💡 Motivation and Context

Changes requested by @philipphofmann here: #3931 (comment)

💚 How did you test it?

  • Existing unit tests pass

📝 Checklist

You have to check all boxes before merging:

  • I reviewed the submitted code.
  • I added tests to verify the changes.
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled.
  • I updated the docs if needed.
  • Review from the native team if needed.
  • No breaking change or entry added to the changelog.
  • No breaking change for hybrid SDKs or communicated to hybrid SDKs.

🔮 Next steps

Copy link

codecov bot commented May 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.868%. Comparing base (3912b16) to head (b3a6377).

Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff              @@
##              main     #3973       +/-   ##
=============================================
+ Coverage   90.824%   90.868%   +0.044%     
=============================================
  Files          594       594               
  Lines        46078     46082        +4     
  Branches     16444     16456       +12     
=============================================
+ Hits         41850     41874       +24     
+ Misses        4158      4027      -131     
- Partials        70       181      +111     
Files Coverage Δ
Sources/Sentry/SentryNetworkTracker.m 96.393% <100.000%> (+0.023%) ⬆️
Sources/Swift/Tools/URLSessionTaskHelper.swift 100.000% <100.000%> (ø)
Tests/SentryTests/URLSessionTaskHelperTests.swift 100.000% <100.000%> (ø)

... and 37 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3912b16...b3a6377. Read the comment docs.

Copy link
Member

@philipphofmann philipphofmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I fixed the Changelog and removed the public keyword for the helper class to merge this faster. Thanks a lot, @maxchuquimia 💯. LGTM.

@philipphofmann philipphofmann merged commit 1ac58a6 into getsentry:main May 14, 2024
62 of 67 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants