Skip to content

Commit

Permalink
ref: Define SDK names inline
Browse files Browse the repository at this point in the history
  • Loading branch information
jennmueng committed Mar 17, 2021
1 parent b1a4f30 commit 2bd2b63
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 8 deletions.
7 changes: 2 additions & 5 deletions src/android/io/sentry/SentryCordova.java
Original file line number Diff line number Diff line change
Expand Up @@ -387,18 +387,15 @@ private SentryLevel getSentryLevelFromString(String level) {
}
}

private final String androidSdk = "sentry.java.android";
private final String nativeSdk = "sentry.native";

private void setEventOriginTag(SentryEvent event) {
SdkVersion sdk = event.getSdk();
if (sdk != null) {
switch (sdk.getName()) {
// If the event is from cordova js, it gets set there and we do not handle it here.
case nativeSdk:
case "sentry.native":
setEventEnvironmentTag(event, "android", "native");
break;
case androidSdk:
case "sentry.java.android":
setEventEnvironmentTag(event, "android", "java");
break;
default:
Expand Down
4 changes: 1 addition & 3 deletions src/ios/SentryCordova.m
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,6 @@
#import <Cordova/CDVAvailability.h>
@import Sentry;

NSString *const cocoaSdk = @"sentry.cocoa";

@implementation SentryCordova

- (void)pluginInitialize {
Expand Down Expand Up @@ -44,7 +42,7 @@ - (void)setEventOriginTag:(SentryEvent *)event {
NSString *sdkName = event.sdk[@"name"];

// If the event is from cordova js, it gets set there and we do not handle it here.
if ([sdkName isEqualToString:cocoaSdk]) {
if ([sdkName isEqualToString:@"sentry.cocoa"]) {
[self setEventEnvironmentTag:event origin:@"ios" environment:@"native"];
}
}
Expand Down

0 comments on commit 2bd2b63

Please sign in to comment.