Skip to content

Commit

Permalink
Bump: Android 6.4.1 (#286)
Browse files Browse the repository at this point in the history
  • Loading branch information
lucas-zimerman committed Sep 15, 2022
1 parent f3dbd4f commit f0c35c2
Show file tree
Hide file tree
Showing 6 changed files with 104 additions and 3 deletions.
1 change: 1 addition & 0 deletions .prettierignore
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
CHANGELOG.md
8 changes: 8 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,13 @@
# Changelog

## Unreleased

### Fixes

- build(android): Bump Android SDK to 6.4.1 ([#286](https://github.com/getsentry/sentry-cordova/pull/286))
- [changelog](https://github.com/getsentry/sentry-java/releases/tag/6.4.1)
- [diff](https://github.com/getsentry/sentry-java/compare/4.1.0...6.4.1)

## 1.0.3

### Fixes
Expand Down
92 changes: 92 additions & 0 deletions CONTRIBUTING.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,92 @@
### Contributing

### Requirements

- Node.JS
- [Cordova](https://www.npmjs.com/package/cordova)
- Some IDE (Visual Studio Code for example)
- Xcode (iOS) and Android Studio (Android)
- CocoaPods (iOS) (sudo gem install cocoapods)
- ios-deploy (for deploying an app on an iOS device) (brew install ios-deploy)
- iOS 11 or higher on a test device.
- run-s (https://www.npmjs.com/package/run-s)

### Building

On the root folder of Sentry Cordova run the following commands:

## all environments

- yarn build

## MacOS additional command

- make (this will build the carthage for Sentry cocoa)

### Testing on a sample project

On the sample project folder, load your local Sentry Cordova with the following command:

- cordova plugin add '../'

If succeeded, Sentry wizzard will be invoked and your project configured with Sentry Cordova.

Addionally, if you want to remove Sentry Cordova you can run the following command:

```
cordova plugin remove sentry-cordova # same command works for removing the local sentry cordova from your project
```

To build your sample project:

```
cordova build ios # Build the iOS solution
cordova build android # Build the Android solution
cordova build # Build both Android and iOS
```

To test your code you can run the following command:

## iOS

```
cordova run ios
```

Or you can open your project on Xcode and build there

```
open ./platforms/ios/projectname.xcworkspace/
```

NOTE: If you pretend to debug your code, it's recommended to have a Real iPhone/iPad.

NOTE2: If you plan to run on Apple simulators, to make life easier, close all simulators before running any
`run`\`build` command.

## Android

```
cordova emulate android
```

Or open the Android folder inside o the Sample app

### Updating Native Libraries

When updating a native library, please make sure to validate with a sample app to fix any break change or broken code.

## iOS

go to 'src/ios/Carfile' and update the version number.

make sure to fix or warn about any break changes with the altered version before submiting a new Pull Request.

## Android

go to 'plugin.xml' and update the SENTRY_ANDROID_SDK_VERSION version number.

### Updating Sentry Cordova on a test app

the process of updating or testing Sentry Cordova on different versions consists on first removing the previous
installed plugin and then installing the desired on afterward.
2 changes: 1 addition & 1 deletion plugin.xml
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
<repo>https://github.com/getsentry/sentry-cordova.git</repo>
<issue>https://github.com/getsentry/sentry-cordova/issues</issue>

<preference name="SENTRY_ANDROID_SDK_VERSION" default="4.1.0"/>
<preference name="SENTRY_ANDROID_SDK_VERSION" default="6.4.1"/>

<engines>
<!-- https://issues.apache.org/jira/browse/CB-10239?jql=labels%20%3D%20cordova-8.0.0 -->
Expand Down
2 changes: 1 addition & 1 deletion src/android/io/sentry/SentryCordova.java
Original file line number Diff line number Diff line change
Expand Up @@ -177,7 +177,7 @@ private void startWithOptions(final JSONObject jsonOptions, final CallbackContex
options.setMaxBreadcrumbs(jsonOptions.getInt("maxBreadcrumbs"));
}
if (jsonOptions.has("enableAutoSessionTracking")) {
options.setEnableSessionTracking(jsonOptions.getBoolean("enableAutoSessionTracking"));
options.setEnableAutoSessionTracking(jsonOptions.getBoolean("enableAutoSessionTracking"));
}
if (jsonOptions.has("sessionTrackingIntervalMillis")) {
options.setSessionTrackingIntervalMillis(jsonOptions.getInt("sessionTrackingIntervalMillis"));
Expand Down
2 changes: 1 addition & 1 deletion src/js/__tests__/wrapper.ts
Original file line number Diff line number Diff line change
Expand Up @@ -102,7 +102,7 @@ describe('Tests Native Wrapper', () => {

NATIVE.setUser({
email: 'hello@sentry.io',
// @ts-ignore Intentional incorrect type to simulate using a double as an id (We had a user open an issue because this didn't work before)
// @ts-ignore Intentional incorrect type to simulate using a double as an id (We had a user open an issue because this didn't work before) https://github.com/getsentry/sentry-react-native/pull/926
id: 3.14159265359,
unique: 123,
});
Expand Down

0 comments on commit f0c35c2

Please sign in to comment.