Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove usage of deprecated requireCordovaModule #120

Merged
merged 1 commit into from
Mar 28, 2019

Conversation

mlegenhausen
Copy link
Contributor

The usage of requireCordovaModule is deprecated and throws an error when used for requiring non codova- modules.

This change was introduced with cordova>=9.

See: apache/cordova-lib#707

@codecov-io
Copy link

codecov-io commented Mar 27, 2019

Codecov Report

Merging #120 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #120   +/-   ##
=======================================
  Coverage   94.96%   94.96%           
=======================================
  Files           9        9           
  Lines         139      139           
  Branches       22       21    -1     
=======================================
  Hits          132      132           
  Misses          6        6           
  Partials        1        1

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 879c11b...90d31fb. Read the comment docs.

Copy link
Member

@HazAT HazAT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thx 👍

@HazAT HazAT merged commit 8e5eb67 into getsentry:master Mar 28, 2019
@mlegenhausen mlegenhausen deleted the require_cordova_module_deprecation branch March 28, 2019 09:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants