Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Mac M1 build #262

Merged
merged 2 commits into from
Apr 25, 2022
Merged

Fix Mac M1 build #262

merged 2 commits into from
Apr 25, 2022

Conversation

lucas-zimerman
Copy link
Collaborator

This PR fixes the build on M1 devices by adding an universal bundle to XCode where it's able to find the appropriate binaries for each target.

Close #252

@lucas-zimerman lucas-zimerman added Type: Bug Platform: iOS Related to, or using the iOS platform labels Apr 22, 2022
@lucas-zimerman lucas-zimerman changed the title Update carthage script Fix Mac M1 build Apr 22, 2022
@lucas-zimerman lucas-zimerman marked this pull request as ready for review April 22, 2022 01:26
Copy link
Member

@bruno-garcia bruno-garcia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@bruno-garcia bruno-garcia merged commit 936b0e4 into main Apr 25, 2022
@bruno-garcia bruno-garcia deleted the fix/m1-build branch April 25, 2022 17:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Platform: iOS Related to, or using the iOS platform Type: Bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot build for ios simulator with Apple M1 macbook
2 participants