Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support custom dist and release has precedence over the pubspec name #139

Merged
merged 2 commits into from Jul 20, 2023
Merged

Support custom dist and release has precedence over the pubspec name #139

merged 2 commits into from Jul 20, 2023

Conversation

marandaneto
Copy link
Contributor

馃摐 Description

Support custom dist and release has precedence over the pubspec's name

馃挕 Motivation and Context

Closes #137
Closes #132

馃挌 How did you test it?

馃摑 Checklist

  • I reviewed submitted code
  • I added tests to verify changes
  • I updated the docs if needed
  • All tests passing
  • No breaking changes

馃敭 Next steps

Update the docs

@marandaneto marandaneto mentioned this pull request Jul 19, 2023
Closed
@marandaneto
Copy link
Contributor Author

@stefanosiano or @kahest can one of you review/approve it? this is causing issues during Flutter web symbolication and creating releases that should not.

kahest
kahest reviewed Jul 20, 2023
View reviewed changes
Copy link
Member

@kahest kahest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 馃殌

@marandaneto marandaneto merged commit 42a9e0d into main Jul 20, 2023
9 checks passed
@marandaneto marandaneto deleted the fix/custom-release-dist branch July 20, 2023 09:23
@marandaneto marandaneto mentioned this pull request Jul 20, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kahest kahest kahest approved these changes

@krystofwoldrich krystofwoldrich Awaiting requested review from krystofwoldrich krystofwoldrich is a code owner

@stefanosiano stefanosiano Awaiting requested review from stefanosiano stefanosiano is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Different namings between android package name or ios bundle id and pubspec's name. Support custom dist
2 participants
@marandaneto @kahest