Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ignore_missing config #85

Merged
merged 4 commits into from Mar 2, 2023

Conversation

qiuyin
Copy link
Contributor

@qiuyin qiuyin commented Mar 1, 2023

📜 Description

config to ignore missing commits previously used in the release

💡 Motivation and Context

add option --ignore-missing to sentry-cli releases set-commits to solve following issue.

There are scenarios in which your repositories may be missing commits previously used in the release. This can happen whenever you modify the commit in question by, for example, amending it, rebasing, or squashing multiple commits together. In this case, Sentry CLI will be unable to find it, and will throw an error that the commit cannot be found.

https://docs.sentry.io/product/cli/releases/#dealing-with-missing-commits

💚 How did you test it?

Before fix, I have this error when deploy

stderr: error: Could not find the SHA of the previous release in the git history. If you limit the clone depth, try to increase it. Otherwise, it means that the commit we are looking for was amended or squashed and cannot be retrieved. Use --ignore-missing flag to skip it and create a new release with the default commits count.

after adding dependency to current pull request branch, the error disappeared

dev_dependencies:
  sentry_dart_plugin:
    git:
      url: https://github.com/qiuyin/sentry-dart-plugin.git
      ref: add-ignore-missing-option

📝 Checklist

  • I reviewed submitted code
  • I added tests to verify changes
  • I updated the docs if needed
  • All tests passing
  • No breaking changes

Test passed
スクリーンショット 2023-03-01 23 17 45

🔮 Next steps

@qiuyin qiuyin marked this pull request as draft March 1, 2023 14:06
@qiuyin qiuyin marked this pull request as ready for review March 1, 2023 15:21
Copy link
Contributor

@marandaneto marandaneto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @qiuyin

@qiuyin
Copy link
Contributor Author

qiuyin commented Mar 2, 2023

@marandaneto
Thanks for your review.
I push other commit to fix CHANGELOG.md after your approved.

And integration-test (macos) has failed. It seems like this failure is not related to this PR, Can I ignore it?
https://github.com/getsentry/sentry-dart-plugin/actions/runs/4304457900/jobs/7508506263

CHANGELOG.md Outdated Show resolved Hide resolved
@marandaneto
Copy link
Contributor

@marandaneto Thanks for your review. I push other commit to fix CHANGELOG.md after your approved.

And integration-test (macos) has failed. It seems like this failure is not related to this PR, Can I ignore it? getsentry/sentry-dart-plugin/actions/runs/4304457900/jobs/7508506263

yes, likely flakiness.
@vaind the same error as before, tried to rerun but it didn't work.

@marandaneto marandaneto merged commit 256b23f into getsentry:main Mar 2, 2023
4 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants