Revert "sync timeouts to andorid"

This reverts commit e7b8cb2.
getsentry · Apr 18, 2023 · 42cc429 · 42cc429
1 parent e7b8cb2
commit 42cc429
Show file tree

Hide file tree

Showing 4 changed files with 1 addition and 18 deletions.
diff --git a/flutter/android/src/main/kotlin/io/sentry/flutter/SentryFlutterPlugin.kt b/flutter/android/src/main/kotlin/io/sentry/flutter/SentryFlutterPlugin.kt
@@ -186,9 +186,6 @@ class SentryFlutterPlugin : FlutterPlugin, MethodCallHandler, ActivityAware {
         event
       }
 
-      args.getIfNotNull<Int>("connectionTimeoutMillis") { options.connectionTimeoutMillis = it }
-      args.getIfNotNull<Int>("readTimeoutMillis") { options.connectionTimeoutMillis = it }
-
       // missing proxy
     }
     result.success("")

diff --git a/flutter/lib/src/integrations/native_sdk_integration.dart b/flutter/lib/src/integrations/native_sdk_integration.dart
@@ -49,8 +49,6 @@ class NativeSdkIntegration extends Integration<SentryFlutterOptions> {
         'maxAttachmentSize': options.maxAttachmentSize,
         'captureFailedRequests': options.captureFailedRequests,
         'enableAppHangTracking': options.enableAppHangTracking,
-        'connectionTimeoutMillis': options.connectionTimeout.inMilliseconds,
-        'readTimeoutMillis': options.readTimeout.inMilliseconds,
       });
 
       options.sdk.addIntegration('nativeSdkIntegration');

diff --git a/flutter/lib/src/sentry_flutter_options.dart b/flutter/lib/src/sentry_flutter_options.dart
@@ -199,12 +199,6 @@ class SentryFlutterOptions extends SentryOptions {
   /// Only available on iOS and macOS.
   bool enableAppHangTracking = true;
 
-  /// Connection timeout. This will only be synced to the Android native SDK.
-  Duration connectionTimeout = Duration(seconds: 5);
-
-  /// Read timeout. This will only be synced to the Android native SDK.
-  Duration readTimeout = Duration(seconds: 5);
-
   /// By using this, you are disabling native [Breadcrumb] tracking and instead
   /// you are just tracking [Breadcrumb]s which result from events available
   /// in the current Flutter environment.

diff --git a/flutter/test/integrations/init_native_sdk_integration_test.dart b/flutter/test/integrations/init_native_sdk_integration_test.dart
@@ -60,8 +60,6 @@ void main() {
         'maxAttachmentSize': 20 * 1024 * 1024,
         'captureFailedRequests': true,
         'enableAppHangTracking': true,
-        'connectionTimeoutMillis': 5000,
-        'readTimeoutMillis': 5000,
       });
     });
 
@@ -98,9 +96,7 @@ void main() {
         ..proguardUuid = fakeProguardUuid
         ..maxAttachmentSize = 10
         ..captureFailedRequests = false
-        ..enableAppHangTracking = false
-        ..connectionTimeout = Duration(milliseconds: 9001)
-        ..readTimeout = Duration(milliseconds: 9002);
+        ..enableAppHangTracking = false;
 
       options.sdk.addIntegration('foo');
       options.sdk.addPackage('bar', '1');
@@ -141,8 +137,6 @@ void main() {
         'maxAttachmentSize': 10,
         'captureFailedRequests': false,
         'enableAppHangTracking': false,
-        'connectionTimeoutMillis': 9001,
-        'readTimeoutMillis': 9002,
       });
     });