fix tests

getsentry · Jun 13, 2024 · 69d7517 · 69d7517
1 parent d780005
commit 69d7517
Show file tree

Hide file tree

Showing 2 changed files with 21 additions and 12 deletions.
diff --git a/flutter/lib/src/native/factory_web.dart b/flutter/lib/src/native/factory_web.dart
@@ -1,11 +1,10 @@
 import 'package:flutter/services.dart';
 
+import '../../sentry_flutter.dart';
 import 'sentry_native_binding.dart';
 
-// ignore: implementation_imports
-import 'package:sentry/src/platform/platform.dart';
-
 // This isn't actually called, see SentryFlutter.init()
-SentryNativeBinding createBinding(Platform _, MethodChannel __) {
+SentryNativeBinding createBinding(SentryFlutterOptions options,
+    {MethodChannel channel = const MethodChannel('sentry_flutter')}) {
   throw UnsupportedError("Native binding is not supported on this platform.");
 }
diff --git a/flutter/test/sentry_native_channel_test.dart b/flutter/test/sentry_native_channel_test.dart
@@ -9,12 +9,13 @@ import 'package:sentry_flutter/sentry_flutter.dart';
 import 'package:sentry_flutter/src/native/factory.dart';
 import 'package:sentry_flutter/src/native/method_channel_helper.dart';
 import 'package:sentry_flutter/src/native/sentry_native_binding.dart';
+import 'package:sentry/src/platform/platform.dart' as platform;
 import 'mocks.dart';
 import 'mocks.mocks.dart';
 import 'sentry_flutter_test.dart';
 
 void main() {
-  for (var platform in [
+  for (var mockPlatform in [
     MockPlatform.android(),
     MockPlatform.iOs(),
     MockPlatform.macOs()
@@ -25,7 +26,7 @@ void main() {
 
       setUp(() {
         final options = SentryFlutterOptions(
-            dsn: fakeDsn, checker: getPlatformChecker(platform: platform))
+            dsn: fakeDsn, checker: getPlatformChecker(platform: mockPlatform))
           // ignore: invalid_use_of_internal_member
           ..automatedTestMode = true;
         channel = MockMethodChannel();
@@ -190,13 +191,22 @@ void main() {
       });
 
       test('startProfiler', () {
-        if (platform.isMacOS || platform.isIOS) {
-          expect(
-              () => sut.startProfiler(SentryId.newId()), throwsArgumentError);
-        } else {
-          expect(() => sut.startProfiler(SentryId.newId()),
-              throwsUnsupportedError);
+        late Matcher matcher;
+        if (mockPlatform.isAndroid) {
+          matcher = throwsUnsupportedError;
+        } else if (mockPlatform.isIOS || mockPlatform.isMacOS) {
+          if (platform.instance.isMacOS) {
+            matcher = throwsA(predicate((e) =>
+                e is Exception &&
+                e.toString().contains('Failed to load Objective-C class')));
+          } else {
+            matcher = throwsA(predicate((e) =>
+                e is ArgumentError &&
+                e.toString().contains('Failed to lookup symbol')));
+          }
         }
+        expect(() => sut.startProfiler(SentryId.newId()), matcher);
+
         verifyZeroInteractions(channel);
       });