Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Codecov action is broken #2043

Closed
vaind opened this issue May 8, 2024 · 6 comments · Fixed by #2118
Closed

Codecov action is broken #2043

vaind opened this issue May 8, 2024 · 6 comments · Fixed by #2118
Labels
CI Platform: Dart testing

Comments

@vaind
Copy link
Collaborator

vaind commented May 8, 2024

Description

The latest report is from three months ago: https://app.codecov.io/gh/getsentry/sentry-dart/commits

action fails with Error: Codecov token not found. Please provide Codecov token with -t flag.
@buenaflor
Copy link
Contributor

ah thanks, we're looking into it

@buenaflor
Copy link
Contributor

should be fixed now

@vaind
Copy link
Collaborator Author

vaind commented Jun 20, 2024

should be fixed now

Still/again doesn't work:
https://github.com/getsentry/sentry-dart/actions/runs/9582784189/job/26422535255#step:8:34

@vaind vaind reopened this Jun 20, 2024
@buenaflor
Copy link
Contributor

dang, thx for noticing

@buenaflor
Copy link
Contributor

#2046 the issue was I only added the fix for the flutter workflow, I need to add it to every other that uses codecov as well

@vaind
Copy link
Collaborator Author

vaind commented Jun 20, 2024

I get it
consider merging #2114 first :)

@buenaflor buenaflor mentioned this issue Jun 20, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
CI Platform: Dart testing
Projects
Mobile & Cross Platform SDK
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: codecov ci getsentry/sentry-dart
2 participants
@vaind @buenaflor