Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run dart_code_metrics on CI and fix current warnings #949

Closed
marandaneto opened this issue Jul 19, 2022 · 2 comments
Closed

Run dart_code_metrics on CI and fix current warnings #949

marandaneto opened this issue Jul 19, 2022 · 2 comments

Comments

@marandaneto
Copy link
Contributor

https://pub.dev/packages/dart_code_metrics

Similar to flutter/flutter#104550

@marandaneto
Copy link
Contributor Author

lib/src/client_reports/client_report.dart:
⚠ constructor ClientReport has unnecessary nullable parameters
(this.timestamp)
at /Users/.../Github/sentry-dart/dart/lib/src/client_reports/client_report.dart:8:3

lib/src/enricher/io_enricher_event_processor.dart:
⚠ method _getRuntimes has unnecessary nullable parameters
(List? runtimes)
at /Users/.../Github/sentry-dart/dart/lib/src/enricher/io_enricher_event_processor.dart:54:3

lib/src/http_client/breadcrumb_client.dart:
⚠ constructor BreadcrumbClient has unnecessary nullable parameters
(Client? client, Hub? hub)
at /Users/.../Github/sentry-dart/dart/lib/src/http_client/breadcrumb_client.dart:45:3

lib/src/http_client/failed_request_client.dart:
⚠ constructor FailedRequestClient has unnecessary nullable parameters
(Client? client, Hub? hub)
at /Users/.../Github/sentry-dart/dart/lib/src/http_client/failed_request_client.dart:67:3
⚠ method _captureEvent has unnecessary nullable parameters
(required Object? exception)
at /Users/.../Github/sentry-dart/dart/lib/src/http_client/failed_request_client.dart:149:3

lib/src/http_client/tracing_client.dart:
⚠ constructor TracingClient has unnecessary nullable parameters
(Client? client, Hub? hub)
at /Users/.../Github/sentry-dart/dart/lib/src/http_client/tracing_client.dart:11:3

lib/src/sentry_envelope_header.dart:
⚠ constructor SentryEnvelopeHeader has unnecessary nullable parameters
(this.eventId, this.sdkVersion)
at /Users/.../Github/sentry-dart/dart/lib/src/sentry_envelope_header.dart:7:3

✖ total declarations (functions, methods and constructors) with unnecessary nullable parameters - 7

@marandaneto marandaneto changed the title Run dart_code_metrics to eliminate dead tests Run dart_code_metrics on CI and fix current warnings May 25, 2023
@marandaneto
Copy link
Contributor Author

this package is DISCONTINUED

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants