New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove unused code from tests #104550
Remove unused code from tests #104550
Conversation
Regarding the dead code this tool found in tests: Ideally, we'd want to avoid accumulating this and there are a couple of lint proposals that would help: dart-lang/linter#1258, dart-lang/linter#685, dart-lang/linter#2395. I believe, any of these would have avoided the dead code from making (or remaining) in the repository. (cc @pq) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is pretty amazing. Nice. Thanks for sharing. And cheers to the |
@goderbauer hi, co-author of Dart Code Metrics here 🙂. So happy to see that the tool helped find and remove unused code! Could you please share more details about the false-positives part? If you don't think this PR is a great place to discuss it, feel free to open an issue here https://github.com/dart-code-checker/dart-code-metrics/issues/new/choose
Thank you! ❤️ |
The dead code was found by running
dart run dart_code_metrics:metrics check-unused-code test
from https://pub.dev/packages/dart_code_metrics inpackages/flutter
.Other notes about the tool: