Use sentryClientName instead of sdk.identifier
#1135
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
denrase
commented
Nov 15, 2022
marandaneto
reviewed
Nov 15, 2022
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| @@ -13,6 +15,7 @@ | |||
| - screenResolution | |||
| - theme | |||
| - Removed isolate name from Dart context. It's now reported via the threads interface. It can be enabled via `options.attachThreads` | |||
| - Use `sentryClientName` instead of `sdk.identifier` ([#1135](https://github.com/getsentry/sentry-dart/pull/1135)) | |||
There was a problem hiding this comment.
- 🚫 The changelog entry seems to be part of an already released section
## 7.0.0.
Consider moving the entry to the## Unreleasedsection, please.
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## v7.0.0 #1135 +/- ##
=========================================
Coverage ? 90.95%
=========================================
Files ? 9
Lines ? 199
Branches ? 0
=========================================
Hits ? 181
Misses ? 18
Partials ? 0 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
marandaneto
reviewed
Nov 15, 2022
marandaneto
approved these changes
Nov 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📜 Description
Use
sentryClientNameinstead ofsdk.identifierinHttpTransportheader.💡 Motivation and Context
Closes #584
💚 How did you test it?
Added test.
📝 Checklist