Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore: Migrate to sentry cocoa v8 #1197

Merged
merged 27 commits into from Jan 16, 2023
Merged

Conversation

denrase
Copy link
Collaborator

@denrase denrase commented Dec 19, 2022

📜 Description

Closes #1161
Closes #1185

💚 How did you test it?

Updated tests

📝 Checklist

  • I reviewed submitted code
  • I added tests to verify changes
  • I updated the docs if needed
  • All tests passing
  • No breaking changes

@denrase denrase marked this pull request as ready for review December 19, 2022 14:24
@codecov-commenter
Copy link

codecov-commenter commented Dec 19, 2022

Codecov Report

❗ No coverage uploaded for pull request base (v7.0.0@fab2a9a). Click here to learn what that means.
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff            @@
##             v7.0.0    #1197   +/-   ##
=========================================
  Coverage          ?   89.90%           
=========================================
  Files             ?      120           
  Lines             ?     3684           
  Branches          ?        0           
=========================================
  Hits              ?     3312           
  Misses            ?      372           
  Partials          ?        0           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@marandaneto
Copy link
Contributor

@denrase I have changed to 8.0.0-rc.1
Not sure if there are more breaking changes, can you take a look?

@brustolin and @philipphofmann would you be kind to review this as well? thanks.

@marandaneto
Copy link
Contributor

The configuration changes in the migration docs should be fixed I guess https://github.com/getsentry/sentry-docs/pull/5939/files
Flutter and Android options naming stay the same for now but we'd need to account for the changes for iOS.

@philipphofmann
Copy link
Member

@denrase I have changed to 8.0.0-rc.1 Not sure if there are more breaking changes, can you take a look?

All the breaking changes are in the Changelog. The migration docs are also almost ready. I have still a PR open for the final touches.

Copy link
Member

@philipphofmann philipphofmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have many more breaking changes in the Changelog. I would be surprised if you don't need more changes in this PR.

I would expect the following changes to bubble up here

  • Rename APM tracking feature flags to tracing (#2450)
    • Rename SentryOptions.enableAutoPerformanceTracking to enableAutoPerformanceTracing
    • Rename SentryOptions.enableUIViewControllerTracking to enableUIViewControllerTracing
    • Rename SentryOptions.enablePreWarmedAppStartTracking to enablePreWarmedAppStartTracing
    • Rename SentryOptions.enableFileIOTracking to enableFileIOTracing
    • Rename SentryOptions.enableCoreDataTracking to enableCoreDataTracing
  • Rename SentryOptions.enableOutOfMemoryTracking to SentryOptions.enableWatchdogTerminationTracking (#2499)

@marandaneto
Copy link
Contributor

#1222 has fixes that are needed for this PR, this PR also has this PR as the target branch, maybe we merge it?

@denrase
Copy link
Collaborator Author

denrase commented Jan 16, 2023

@marandaneto CI seems happy now. Rdy for re-review.

CHANGELOG.md Outdated Show resolved Hide resolved
Copy link
Contributor

@marandaneto marandaneto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left 2 comments, but other than that, LGTM.

CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
@marandaneto marandaneto merged commit 8bea1f1 into v7.0.0 Jan 16, 2023
@marandaneto marandaneto deleted the chore/migrate-to-sentry-cocoa-v8 branch January 16, 2023 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants