Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sentry Isolate Extension #1266

Merged
merged 16 commits into from Mar 6, 2023
Merged

Sentry Isolate Extension #1266

merged 16 commits into from Mar 6, 2023

Conversation

denrase
Copy link
Collaborator

@denrase denrase commented Feb 6, 2023

📜 Description

Add extension & helper to handle isolate errors with Sentry.

Closes #608

💚 How did you test it?

Moved existing tests.

📝 Checklist

  • I reviewed submitted code
  • I added tests to verify changes
  • No new PII added or SDK only sends newly added PII if sendDefaultPii is enabled
  • I updated the docs if needed
  • All tests passing
  • No breaking changes

@denrase denrase changed the title add sentry isolate Sentry Isolate Extension Feb 6, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Feb 6, 2023

Messages
📖 Do not forget to update Sentry-docs with your feature once the pull request gets approved.

Generated by 🚫 dangerJS against cc68ce6

@codecov
Copy link

codecov bot commented Feb 6, 2023

Codecov Report

Patch coverage: 95.83% and project coverage change: +1.80 🎉

Comparison is base (c60752d) 88.73% compared to head (cc68ce6) 90.53%.

Additional details and impacted files
@@            Coverage Diff             @@
##           v7.0.0    #1266      +/-   ##
==========================================
+ Coverage   88.73%   90.53%   +1.80%     
==========================================
  Files         122       50      -72     
  Lines        3818     1649    -2169     
==========================================
- Hits         3388     1493    -1895     
+ Misses        430      156     -274     
Impacted Files Coverage Δ
file/lib/src/sentry_file_extension.dart 80.00% <ø> (ø)
flutter/lib/src/binding_wrapper.dart 100.00% <ø> (ø)
flutter/lib/src/jvm/jvm_exception.dart 100.00% <ø> (ø)
...er_interaction/sentry_user_interaction_widget.dart 96.49% <ø> (ø)
flutter/lib/src/sentry_flutter.dart 93.15% <50.00%> (ø)
dio/lib/src/dio_error_extractor.dart 100.00% <100.00%> (ø)
dio/lib/src/dio_event_processor.dart 97.05% <100.00%> (+0.63%) ⬆️
dio/lib/src/sentry_dio_extension.dart 93.33% <100.00%> (+1.02%) ⬆️
file/lib/src/sentry_file.dart 54.13% <100.00%> (ø)
...nt_processor/flutter_enricher_event_processor.dart 94.18% <100.00%> (ø)
... and 154 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@denrase denrase marked this pull request as ready for review February 6, 2023 13:37
@marandaneto
Copy link
Contributor

@denrase are we adding extensions to Isolate.spawn on this PR as well?

@denrase
Copy link
Collaborator Author

denrase commented Feb 9, 2023

@marandaneto I will try to come up with something. Since there are no static extensions, we might introduce some additional helper so users don't have to do the spawn paused, add observer, resume isolate dance boilerplate.

Copy link
Contributor

@marandaneto marandaneto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a few comments but overall pretty good.
@denrase thanks.

@marandaneto marandaneto merged commit dbe709e into v7.0.0 Mar 6, 2023
80 checks passed
@marandaneto marandaneto deleted the feat/isolate-extension branch March 6, 2023 13:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants