New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sentry Isolate Extension #1266
Sentry Isolate Extension #1266
Conversation
|
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## v7.0.0 #1266 +/- ##
==========================================
+ Coverage 88.73% 90.53% +1.80%
==========================================
Files 122 50 -72
Lines 3818 1649 -2169
==========================================
- Hits 3388 1493 -1895
+ Misses 430 156 -274
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
@denrase are we adding extensions to |
@marandaneto I will try to come up with something. Since there are no static extensions, we might introduce some additional helper so users don't have to do the spawn paused, add observer, resume isolate dance boilerplate. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left a few comments but overall pretty good.
@denrase thanks.
📜 Description
Add extension & helper to handle isolate errors with Sentry.
Closes #608
💚 How did you test it?
Moved existing tests.
📝 Checklist
sendDefaultPii
is enabled