Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add isolate extension to readmes #1390

Merged
merged 1 commit into from
Apr 18, 2023
Merged

Add isolate extension to readmes #1390

merged 1 commit into from
Apr 18, 2023

Conversation

marandaneto
Copy link
Contributor

📜 Description

#skip-changelog

💡 Motivation and Context

💚 How did you test it?

📝 Checklist

  • I reviewed submitted code
  • I added tests to verify changes
  • No new PII added or SDK only sends newly added PII if sendDefaultPii is enabled
  • I updated the docs if needed
  • All tests passing
  • No breaking changes

🔮 Next steps

@codecov
Copy link

codecov bot commented Apr 17, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (ed605cc) 89.91% compared to head (ff63abd) 89.91%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1390   +/-   ##
=======================================
  Coverage   89.91%   89.91%           
=======================================
  Files         179      179           
  Lines        5759     5759           
=======================================
  Hits         5178     5178           
  Misses        581      581           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@github-actions
Copy link
Contributor

Android Performance metrics 🚀

  Plain With Sentry Diff
Startup time 365.04 ms 464.70 ms 99.66 ms
Size 6.06 MiB 7.03 MiB 993.53 KiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
11fb408 320.10 ms 380.24 ms 60.14 ms
fdac48a 329.50 ms 396.46 ms 66.96 ms
a7acb24 301.00 ms 357.38 ms 56.38 ms
eecbbca 324.37 ms 352.49 ms 28.12 ms
24f71aa 358.49 ms 455.90 ms 97.41 ms
2f8f173 323.31 ms 373.29 ms 49.97 ms
6957bfd 325.88 ms 380.30 ms 54.43 ms
6325c3b 339.33 ms 409.86 ms 70.53 ms
d7758e8 300.12 ms 349.88 ms 49.76 ms
40680d3 323.55 ms 390.29 ms 66.73 ms

App size

Revision Plain With Sentry Diff
11fb408 6.06 MiB 7.10 MiB 1.04 MiB
fdac48a 6.06 MiB 7.09 MiB 1.03 MiB
a7acb24 5.94 MiB 6.95 MiB 1.01 MiB
eecbbca 5.94 MiB 6.89 MiB 975.78 KiB
24f71aa 6.06 MiB 7.03 MiB 990.30 KiB
2f8f173 5.94 MiB 6.95 MiB 1.01 MiB
6957bfd 5.94 MiB 6.95 MiB 1.01 MiB
6325c3b 5.94 MiB 6.96 MiB 1.02 MiB
d7758e8 5.94 MiB 6.95 MiB 1.01 MiB
40680d3 6.06 MiB 7.03 MiB 989.25 KiB

Copy link
Member

@krystofwoldrich krystofwoldrich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@marandaneto marandaneto merged commit b98109e into main Apr 18, 2023
@marandaneto marandaneto deleted the chore/isolate-extension branch April 18, 2023 16:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants